Set go 1.21.0, remove toolchain 1.22 statement #1217
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
Explicitly sets go 1.21.0 in go.mod and removes the "toolchain" statement that got automatically put there by a go mod tidy.
We don't want to force a go 1.22 toolchain at this point. It looks like with go 1.21 it's encouraged to set an X.Y.Z version as you need an explicit release version for the toolchain stuff to work. In this case go mod tidy added the x.y.z and also added a toolchain statement with the go version used (I assume?) because we picked up syncthing which itself had a go.mod with
go 1.21.0
.So simply using
go 1.21.0
in our go.mod means we can now run go mod tidy and it won't add a "toolchain" directive to the file on us.This is better explained here: golang/go#62278 (comment)
Is there anything that requires special attention?
Related issues: