Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rsync e2e usepam no #1478

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

tesshuflower
Copy link
Contributor

Describe what this PR does

UsePam no for sshd_config

e2e running on ubuntu 24.04 (not sure of exact cause) is having issues with sshd allowing root access which is required for rsync ssh. Seems to be related to PAM.

Very strange and unsure of exact cause, but seems to be recreatable with kind running on an ubuntu 24.04 host. Something in PAM is simply failing and not allowing root to login.

Is there anything that requires special attention?

Related issues:

e2e running on ubuntu 24.04 (not sure of exact cause)
is having issues with sshd allowing root access which
is required for rsync ssh.  Seems to be related to
PAM.

Signed-off-by: Tesshu Flower <[email protected]>
Copy link
Contributor

openshift-ci bot commented Dec 6, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

sonarqubecloud bot commented Dec 6, 2024

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.2%. Comparing base (11d9889) to head (d2cfea1).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1478     +/-   ##
=======================================
- Coverage   66.3%   66.2%   -0.2%     
=======================================
  Files         57      57             
  Lines       7474    7474             
=======================================
- Hits        4959    4950      -9     
- Misses      2230    2236      +6     
- Partials     285     288      +3     

see 1 file with indirect coverage changes

@tesshuflower tesshuflower marked this pull request as ready for review December 6, 2024 14:20
@tesshuflower
Copy link
Contributor Author

/retest

1 similar comment
@tesshuflower
Copy link
Contributor Author

/retest

@tesshuflower
Copy link
Contributor Author

/cc @JohnStrunk

@openshift-ci openshift-ci bot requested a review from JohnStrunk December 6, 2024 16:28
Copy link
Member

@JohnStrunk JohnStrunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Dec 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnStrunk, tesshuflower

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JohnStrunk,tesshuflower]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 0f8c557 into backube:main Dec 6, 2024
32 checks passed
@tesshuflower tesshuflower deleted the rsync-e2e-usepam-no branch December 6, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants