-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rsync e2e usepam no #1478
Rsync e2e usepam no #1478
Conversation
e2e running on ubuntu 24.04 (not sure of exact cause) is having issues with sshd allowing root access which is required for rsync ssh. Seems to be related to PAM. Signed-off-by: Tesshu Flower <[email protected]>
Signed-off-by: Tesshu Flower <[email protected]>
Skipping CI for Draft Pull Request. |
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1478 +/- ##
=======================================
- Coverage 66.3% 66.2% -0.2%
=======================================
Files 57 57
Lines 7474 7474
=======================================
- Hits 4959 4950 -9
- Misses 2230 2236 +6
- Partials 285 288 +3 |
/retest |
1 similar comment
/retest |
/cc @JohnStrunk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnStrunk, tesshuflower The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Describe what this PR does
UsePam no for sshd_config
e2e running on ubuntu 24.04 (not sure of exact cause) is having issues with sshd allowing root access which is required for rsync ssh. Seems to be related to PAM.
Very strange and unsure of exact cause, but seems to be recreatable with kind running on an ubuntu 24.04 host. Something in PAM is simply failing and not allowing root to login.
Is there anything that requires special attention?
Related issues: