Add null check before accessing type.tsymbol in CodeAnalyzer
#43733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdulmina
requested review from
sameerajayasoma,
hasithaa,
gimantha and
MaryamZi
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #43733 +/- ##
============================================
- Coverage 77.55% 77.41% -0.15%
+ Complexity 58722 58616 -106
============================================
Files 3447 3445 -2
Lines 219658 219173 -485
Branches 28915 28969 +54
============================================
- Hits 170365 169663 -702
- Misses 39892 40081 +189
- Partials 9401 9429 +28 ☔ View full report in Codecov by Sentry. |
Comment on lines
+2807
to
+2808
| if (cIExpr.userDefinedType != null && type.tsymbol != null && | ||
| Symbols.isFlagOn(type.tsymbol.flags, Flags.DEPRECATED)) { |
There was a problem hiding this comment.
Here, we need to check whether the DEPRECATED flag is present in the symbol of the userDefinedType (BLangUserDefinedType), isn't it?
MaryamZi
reviewed
Jan 8, 2025
| @@ -2804,7 +2804,8 @@ public void visit(BLangTypeInit cIExpr, AnalyzerData data) { | |||
| analyzeExprs(cIExpr.argsExpr, data); | |||
| analyzeExpr(cIExpr.initInvocation, data); | |||
| BType type = cIExpr.getBType(); | |||
| if (cIExpr.userDefinedType != null && Symbols.isFlagOn(type.tsymbol.flags, Flags.DEPRECATED)) { | |||
| if (cIExpr.userDefinedType != null && type.tsymbol != null && | |||
There was a problem hiding this comment.
Shall we make this a draft PR? I wouldn't introduce this change without getting the issue reproduced.
|
Closing this as this is not the correct fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$title
Fixes #43286