-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ingress controller posthook #3443
Conversation
126b716
to
db1f0cf
Compare
db1f0cf
to
411076e
Compare
internal/cluster/clustersetup/activity_install_ingress_controller.go
Outdated
Show resolved
Hide resolved
@@ -1,4 +1,4 @@ | |||
// Copyright © 2018 Banzai Cloud | |||
// Copyright © 2019 Banzai Cloud |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: is there a reason we use a different nomenclature for this activity compared to the similar cluster autoscaler one (install
here versus deploy
at the CA)? If these activities do the same, I as a reader would intuitively expect them to be called similarly for clarity purposes.
Whichever fits the case better is up for consideration.
(If we decide to rename, don't forget to rename both the file and the code references including the activity name.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see there are divergences already, because NPLS is also called install
while the cluster autoscaler is called deploy
, so this kind of invalidates my comment for now (consolidating these is going to be a bigger refactor because the divergence is not being introduced here which I originally assumed).
You can skip this thread.
(Not resolving the thread for visibility purposes.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will rename it to deploy, since autoscaler is newer and you too preferred that name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is debatable, because in Helm terminology we are installing releases and not deploying something, but I'm fine with either names for now as there is going to be at least one outlier.
internal/cluster/clustersetup/activity_install_ingress_controller.go
Outdated
Show resolved
Hide resolved
internal/cluster/clustersetup/activity_install_ingress_controller.go
Outdated
Show resolved
Hide resolved
internal/cluster/clustersetup/activity_install_ingress_controller.go
Outdated
Show resolved
Hide resolved
internal/cluster/clustersetup/activity_install_ingress_controller.go
Outdated
Show resolved
Hide resolved
411076e
to
25c1944
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well I definitely didn't expect this much hassle for the provider information, but that's the easiest way to propagate, then it's fine.
e714838
to
400d36b
Compare
What's in this PR?
Why?
To be able to deprecate post hook functionality.
Checklist