Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass state accesses / simPayload to _postCheck #103

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

mdehoog
Copy link
Contributor

@mdehoog mdehoog commented Oct 29, 2024

These were removed as parameters in #97. However, after looking at the changes in ethereum-optimism/superchain-ops#356, it seems simpler if they are just passed in.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Oct 29, 2024

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@mdehoog mdehoog changed the title Pass state accessses / simPayload to _postCheck Pass state accesses / simPayload to _postCheck Oct 29, 2024
@mdehoog mdehoog merged commit c3218d4 into main Oct 29, 2024
2 checks passed
@mdehoog mdehoog deleted the michael/pass-simulation-accesses branch October 29, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants