Fix simulation contract deployment during broadcast #110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Simulation.sol
library had somepublic
methods on it, which causes it to be a separate library contract. This means that anything that interacts withSimulation
under abroadcast
context (e.g. withinvm.startBroadcast()
) will deploy the Simulation contract.This PR switches the library methods from
public
tointernal
which causes the library to be embedded in the script, which prevents it from being deployed.It also more narrowly scopes down the broadcast context to only apply to the single
safe.execTransaction
to prevent this from happening again in future changes.Also added a feature that skips signatures from non-owning addresses (and warning via console).