Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI on macOS runners #94

Merged
merged 1 commit into from
Jul 13, 2024
Merged

Conversation

Merinorus
Copy link
Contributor

@Merinorus Merinorus commented Jun 24, 2024

Following the CI failing on PR #92.

This PR contains the following:

  • Checkout workflow updated to v4
  • Setup python workflow updated to v5
  • Fix python pip cache in CI
  • Test python 3.7 against macOS x86 instead of ARM

Fix #93

- Checkout workflow updated to v4
- Setup python workflow updated to v5
- Fix python pip cache in CI
- Test python 3.7 against macOS x86 instead of ARM

Fix bauerji#93
@Merinorus Merinorus changed the title Upgrade and fix CI workflows Fix CI on macOS runners Jun 24, 2024
@yctomwang yctomwang self-requested a review June 25, 2024 13:26
@Merinorus
Copy link
Contributor Author

I guess we need a repo administrator to change which build steps are mandatory, otherwise, we are stuck :)

@yctomwang
Copy link
Collaborator

@Merinorus yes, despite been a collabroator, i cant change the build step :( I think we need Jiri the owner

@yctomwang
Copy link
Collaborator

@bauerji Hey Jiri in order to move forward, we really need to get rid of the the build(3.7) and build(3.8) to be able to merge the code, otherwise we wont be able to merge any code as the merge pull request is grey due to pending for build3.7 and build3.8. Would be extremely nice if you could remove them!

@bauerji
Copy link
Owner

bauerji commented Jul 8, 2024

@bauerji Hey Jiri in order to move forward, we really need to get rid of the the build(3.7) and build(3.8) to be able to merge the code, otherwise we wont be able to merge any code as the merge pull request is grey due to pending for build3.7 and build3.8. Would be extremely nice if you could remove them!

Hey, could you please elaborate a bit on what do you think must be done by me? 🙏 Afaik the configuration of builds is defined in tests.yaml which can be changed normally by PRs. Or is there something else in the project configuration?

@Merinorus
Copy link
Contributor Author

Merinorus commented Jul 8, 2024

Hi @bauerji , I think the branch protection rules should be changed (repo settings -> Branches).

At Require status checks to pass before merging, you can require all the following status checks:

image

The other checks (build 3.7, build 3.8) should not be required, as from this PR the project does not have these checks anymore.

Note: the checks are the same, but their name have changed so GitHub has lost track.

@bauerji
Copy link
Owner

bauerji commented Jul 8, 2024

@Merinorus, great, thank you for the explanation. Done!

@yctomwang yctomwang merged commit 8595fa8 into bauerji:master Jul 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI is failing on macOS
3 participants