Feature/codingstandard changes (#97)

* space added or removed as per coding-standard instruction * Unescaped output detectedUnescaped output detected resolved * tag @Package removed * tag @pakage removed * removed php shorttags * removed php shorttags * updated the short comments and spacess addition and removal * patch added * module version update * module version update * compile error * module version update * removing setup-data files * Data patches files converted of Setup files * removed the logger * version updated * Removed echo as per test result * updated the version * test commit * Test commit for version update * Updated for compatibility of 2.4.4 and php 8.1 * Updated for compatibility of 2.4.4 and php8.1 * Updated code changes as per varnish test report * Updated code changes as per varnish test report * Reverted the latest changes * cron issue resolution * updated for cron issue * as per compatiblity 2.4.5 Co-authored-by: Vivek Tiwari <[email protected]> Co-authored-by: Vtiwari01 <[email protected]>
bazaarvoice · Sep 14, 2022 · 06192be · 06192be
1 parent 80d4b7d
commit 06192be
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/Logger/Logger.php b/Logger/Logger.php
@@ -11,6 +11,7 @@
 use Bazaarvoice\Connector\Api\ConfigProviderInterface;
 use Exception;
 use Magento\Framework\App\State;
+use Monolog\DateTimeImmutable;
 
 /**
  * Class Logger
@@ -71,10 +72,9 @@ public function debug($message, array $context = []): void
      * @param int    $level
      * @param string $message
      * @param array  $context
-     *
      * @return bool
      */
-    public function addRecord($level, $message, array $context = []): bool
+    public function addRecord(int $level, string $message, array $context = [], DateTimeImmutable $datetime = null): bool
     {
         if (is_array($message)) {
             $message = print_r($message, $return = true);

diff --git a/Model/XMLWriter.php b/Model/XMLWriter.php
@@ -29,8 +29,10 @@ public function writeElement($name, $content = null, $cdata = false): bool
             $this->startElement($name);
             $this->writeCdata($content);
             $this->endElement();
+            return true;
         } else {
             parent::writeElement($name, $content);
+            return true;
         }
     }
 
@@ -45,8 +47,10 @@ public function writeRaw($content = null, $cdata = false): bool
         $content = trim((string)$content);
         if ($cdata) {
             $this->writeCdata($content);
+            return true;
         } else {
             parent::writeRaw($content);
+            return true;
         }
     }
 }