fix: make specs pass with ruby 3.4 #1092
Open
+9
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hash serialization to string seems to be different in ruby 3.4:
$ chruby 3.3
$ ruby -e 'puts ({"a" => 1}).to_s'
{"a"=>1}
$ chruby 3.4
$ ruby -e 'puts ({"a" => 1}).to_s'
{"a" => 1}
This change makes specs to use the serialized string instead of the hardcoded
string, so the output is now independent of the way the string is serialized.
Juanmcuello
force-pushed
the
ruby-3.4-fix-hash-specs
branch
from
0df4a45 to
cccfedd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hash serialization to string seems to be different in ruby 3.4:
$ chruby 3.3
$ ruby -e 'puts ({"a" => 1}).to_s'
{"a"=>1}
$ chruby 3.4
$ ruby -e 'puts ({"a" => 1}).to_s'
{"a" => 1}
This change makes specs to use the serialized string instead of the hardcoded string, so the output is now independent of the way the string is serialized.