Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub Workflow to build services on release #803

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add GitHub Workflow to build services on release #803

wants to merge 6 commits into from

Conversation

i5okie
Copy link

@i5okie i5okie commented Jan 8, 2025 •
edited
Loading

  • Build VCR Agent
  • Build VCR API
  • Build VCR Solr

@i5okie i5okie requested a review from WadeBarnes January 8, 2025 21:59
@i5okie i5okie self-assigned this Jan 8, 2025
@i5okie i5okie marked this pull request as draft January 8, 2025 22:02
WadeBarnes
WadeBarnes requested changes Jan 9, 2025
View reviewed changes
.github/workflows/build_release.yaml Outdated Show resolved Hide resolved
i5okie added 2 commits January 10, 2025 13:17
@i5okie
Expand workflow
2ca5afc 
Signed-off-by: Ivan P <[email protected]>
@i5okie
Update description
a15e8ef 
Signed-off-by: Ivan P <[email protected]>
@i5okie i5okie changed the title Add GitHub Workflow to build vcr-agent release image Add GitHub Workflow to build services on release Jan 13, 2025
@i5okie i5okie requested a review from WadeBarnes January 13, 2025 17:40
@i5okie i5okie marked this pull request as ready for review January 13, 2025 19:37
@i5okie
Build db
92d4ed6 
Signed-off-by: Ivan P <[email protected]>
esune
esune requested changes Jan 13, 2025
View reviewed changes
Copy link
Member

@esune esune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small comments, looks good overall

.github/workflows/build_release.yaml Outdated Show resolved Hide resolved
.github/workflows/build_release.yaml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esune esune esune approved these changes

@WadeBarnes WadeBarnes Awaiting requested review from WadeBarnes

Requested changes must be addressed to merge this pull request.

Assignees

@i5okie i5okie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@i5okie @esune @WadeBarnes