Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security Updates #93

Merged
merged 5 commits into from
Mar 26, 2024
Merged

Security Updates #93

merged 5 commits into from
Mar 26, 2024

Conversation

TimCsaky
Copy link
Contributor

@TimCsaky TimCsaky commented Mar 14, 2024

https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-2658

  • Update npm packages
  • update base image in Dockerfile
  • add helmet.js for security
  • remove network policy restriction
  • github actions updates

Description

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@TimCsaky TimCsaky force-pushed the npm-update branch 3 times, most recently from 5dee7e2 to 359cca3 Compare March 20, 2024 19:22
Update to final Vue2 version
switch to @babel/eslint-parser
@TimCsaky TimCsaky marked this pull request as ready for review March 20, 2024 23:33
Copy link

Coverage Report (Application)

Totals Coverage
Statements: 12% ( 27 / 225 )
Methods: 10.34% ( 3 / 29 )
Lines: 14.71% ( 20 / 136 )
Branches: 6.67% ( 4 / 60 )

@TimCsaky TimCsaky force-pushed the npm-update branch 2 times, most recently from 28d8c03 to f7ffffa Compare March 21, 2024 20:58
Copy link

Coverage Report (Frontend)

Totals Coverage
Statements: 32.71% ( 35 / 107 )
Methods: 33.33% ( 9 / 27 )
Lines: 40.38% ( 21 / 52 )
Branches: 17.86% ( 5 / 28 )

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 44622 lines exceeds the maximum allowed for the inline comments feature.

Copy link

codeclimate bot commented Mar 21, 2024

Code Climate has analyzed commit b449289 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 21.8% (-0.3% change).

View more on Code Climate.

Dockerfile Outdated Show resolved Hide resolved
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 44622 lines exceeds the maximum allowed for the inline comments feature.

@TimCsaky TimCsaky requested a review from jujaga March 25, 2024 18:17
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 44656 lines exceeds the maximum allowed for the inline comments feature.

@jujaga jujaga merged commit 219c0a0 into master Mar 26, 2024
18 of 20 checks passed
@jujaga jujaga deleted the npm-update branch March 26, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants