Update npm dependencies, Node, GitHub Actions; swap out keycloak-connect for jsonwebtoken #95
Conversation
Coverage Report (Application)
|
Coverage Report (Frontend)
|
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| /** | ||
| * Performs JWT verification. | ||
| */ | ||
| authenticate: (req, res, next) => { |
There was a problem hiding this comment.
Function authenticate has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
| /** | ||
| * Performs JWT verification. | ||
| */ | ||
| authenticate: (req, res, next) => { |
There was a problem hiding this comment.
Function authenticate has 40 lines of code (exceeds 25 allowed). Consider refactoring.
|
Code Climate has analyzed commit 0352b94 and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 0.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 20.2% (-1.6% change). View more on Code Climate. |
keycloak-connect has since been deprecated
norrisng-bc
force-pushed
the
chore/dependency-updates
branch
from
a446f8d to
0352b94
Compare
| /** | ||
| * Performs JWT verification. | ||
| */ | ||
| authenticate: (req, res, next) => { |
There was a problem hiding this comment.
Function authenticate has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
| /** | ||
| * Performs JWT verification. | ||
| */ | ||
| authenticate: (req, res, next) => { |
There was a problem hiding this comment.
Function authenticate has 39 lines of code (exceeds 25 allowed). Consider refactoring.
There was a problem hiding this comment.
all looks fine to me.
The helm chart/github actions doesnt create a separate config-map and environment variables for the pr deployment.
I did just manually add FRONTEND_KC_PUBLICKEY in openshift (dev) so if the pr is updated it should work now.
But when it's merged to master it should work fine anyway.
| healthCheck(req, res, next); | ||
| }); | ||
|
|
||
| routes.post('/template/render', keycloak.protect(protector), (req, res, next) => { |
There was a problem hiding this comment.
I think this keycloak-protect() function we were using before was only verifying the jwt was from the realm in server.keycloak properties, and not verifying 'audience'.
But with the new authenticate() function we are instead verifying the jwt came from the realm and has audience matching attributes of frontend.keyclaok.
But I think the new pattern is correct.
Description
keycloak-connectforjsonwebtoken(it's since been deprecated)https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3623
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist
Further comments
N/A