feature/deseng745: Added multi-select checkboxes for project type. Cleaned up form CSS. #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jareth-whitney
commented
Nov 22, 2024
jareth-whitney
commented
- Added multi-select checkboxes for project type
- Cleaned up form CSS
…eaned up form CSS.
Baelx
approved these changes
Nov 25, 2024
| <label>File name</label> | ||
| <p>{{ logo.controls.name.value }}</p> | ||
| </div> | ||
| <div class="logo-link-container"> | ||
| <div class="logo-link-container full-wide"> |
There was a problem hiding this comment.
Thanks a lot for cleaning up some of the display in the backend!
| @@ -82,6 +82,12 @@ export class AddEditProjectComponent implements OnInit, AfterViewInit, OnDestroy | |||
| 'Plan Implementation and Monitoring' | |||
| ]; | |||
|
|
|||
| public projectTypes: Array<Object> = [ | |||
There was a problem hiding this comment.
You can use the ProjectTypes type that you defined in project.ts here
| * | ||
| * @returns {Array} Array of project type strings. | ||
| */ | ||
| private getTypesFormValues(): Project['projectTypes'] { |
There was a problem hiding this comment.
You could use the ProjectTypes type here too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.