Migrate to PrimeVue 4.0 #234
Conversation
Coverage Report (Application)
|
Coverage Report (Frontend)
|
|
We are putting together a Figma file with screenshots and styling markups for all the needed changes. In the meantime, here are a couple bugs we noticed:
|
|
Here are all the needed changes besides the bugs mentioned above. https://www.figma.com/design/udtqyDmqaYte03ANaS10S2/PAT?node-id=5716-457 |
…ation, fix map resize
Replacing depreciated component Dropdown with Select Updated renamed components, inputswitch to toggleswitch, sidebar to drawer Update Stepper component to new version Update Accordion component to new format, fix submission intake navigation, fix map resize Replace depreciated TabView component with Tabs Primevue theming/CSS changes, handle input component blur events WIP updating color vars
kyle1morel
force-pushed
the
feature/primevue-update
branch
from
c98db7a to
38d2236
Compare
|
|
It's looking good! A few more changes needed besides the ones from Subin. Please check out this new section in the Figma file: |
|
frontend/src/components/housing/submission/SubmissionIntakeForm.vue
Outdated
Show resolved
Hide resolved
frontend/src/components/housing/submission/SubmissionsNavigator.vue
Outdated
Show resolved
Hide resolved
| $app-link-text: #1a5a96; | ||
| $app-link-text-hover: #00f; | ||
| $app-hover: #4696EC; | ||
| $app-outline-on-primary: #fff; | ||
| $app-out-of-focus: #ccc; |
There was a problem hiding this comment.
Consider putting all these hexcodes into the primitives section of ThemeOverride.ts and refer to them using var(). That way there's only one place to define extra hexcodes and using only one method to refer to them rather than mixing $app- and var() methods. Could get ride of variables.scss entirely that way.
Not sure if all these hexcodes are still being used.
There was a problem hiding this comment.
Please see which covers this: https://apps.nrs.gov.bc.ca/int/jira/browse/PADS-430
Description
Update from PrimeVue 3.x to 4.x
Migrate from PrimeFlex to TailwindCSS + PrimeUI Plugin
Create custom PrimeVue theme override based on BCGov mandated colours
Update styling to as closely match previous version as possible.
Types of changes
Bug fix (non-breaking change which fixes an issue)
Documentation (non-breaking change with enhancements to documentation)
Breaking change (fix or feature that would cause existing functionality to change)
Checklist
Further comments