Proponent Contact Profile #235

sanjaytkbabu · 2025-01-07T23:09:00Z

Description

Contact management

Frontend changes:
New contactProfileView added for viewing & updating contact info
New contactSearchParams & contactService added for searching and updating contacts
Updates - HeaderMenu, en-CA, application enums, router, authzStore

Backend changes:
New - controller, route for searching and updating contacts
New contactSearch type
New migration added for creating contact resource,
Updates - enquiry, submission controllers upsert calls, user service to create contact on login, renamed contacts validator

Types of changes

Checklist

I have read the CONTRIBUTING doc
I have checked that unit tests pass locally with my changes
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)

Further comments

github-actions · 2025-01-07T23:10:16Z

Coverage Report (Frontend)

Totals
Statements:	46.78% ( 3268 / 6986 )
Methods:	35.69% ( 419 / 1174 )
Lines:	54.81% ( 1916 / 3496 )
Branches:	40.28% ( 933 / 2316 )

github-actions · 2025-01-07T23:10:20Z

Coverage Report (Application)

Totals
Statements:	36.8% ( 1104 / 3000 )
Methods:	26.82% ( 136 / 507 )
Lines:	48.7% ( 728 / 1495 )
Branches:	24.05% ( 240 / 998 )

app/src/controllers/contact.ts

slhurley · 2025-01-08T16:14:07Z

Look is great to me but a few issues:

Phone number should look like it does on the intake form with brackets around the area code etc.
Phone number validation error message is not intuitive
Phone number validation error sticks and allows you to leave with it still on the screen. It appears to let you save and leave to "Get Started" after you blank out the phone number even though it doesn't actually save a blank. Review the validation on this.
Check PADS-403 changes...you will need to conform with that change.
Design mentioned the Get Started button should not be available until all fields are filled in. Check with UX.

Subin1Doo · 2025-01-08T18:51:32Z

Looking great! Here are some things to look at

Getting a 422 error when trying to save the contact info.. maybe this is just me?
Increase drop shadow to make the contact profile box look more evident
"Get started" button should only show up for first-time login proponents and only when they've filled out their contact info and hit save for the first time
Edit button should be hidden when users are editing
Edit button styling: Button outline only shows when user hover/ clicks on the button, check Figma
Save button not working for me, so not sure if the success message banner is there.. "Success: Contact saved" banner should appear
Save and cancel button too close to the last field of the contact info, increase spacing.

Thank you!!

sanjaytkbabu · 2025-01-08T22:34:11Z

Look is great to me but a few issues:

Phone number should look like it does on the intake form with brackets around the area code etc.

Phone number validation error message is not intuitive

Phone number validation error sticks and allows you to leave with it still on the screen. It appears to let you save and leave to "Get Started" after you blank out the phone number even though it doesn't actually save a blank. Review the validation on this.

Check PADS-403 changes...you will need to conform with that change.

Design mentioned the Get Started button should not be available until all fields are filled in. Check with UX.

done!
re: PADS-403 - I'm reusing the code for the dropdown, it will show the new dropdown when that code gets merged.

sanjaytkbabu · 2025-01-08T22:38:55Z

Look is great to me but a few issues:

Phone number should look like it does on the intake form with brackets around the area code etc.

Phone number validation error message is not intuitive

Phone number validation error sticks and allows you to leave with it still on the screen. It appears to let you save and leave to "Get Started" after you blank out the phone number even though it doesn't actually save a blank. Review the validation on this.

Check PADS-403 changes...you will need to conform with that change.

Design mentioned the Get Started button should not be available until all fields are filled in. Check with UX.

done! re: PADS-403 - I'm reusing the code for the dropdown, it will show the new dropdown when that code gets merged.

done!

github-actions · 2025-01-10T00:03:40Z

Release bb527d8 deployed at https://pcns-dev-pr-235.apps.silver.devops.gov.bc.ca

kyle1morel · 2025-01-09T18:29:40Z

app/src/controllers/contact.ts

+      const contactIds = mixedQueryToArray(req.query.contactId);
+      let userIds = mixedQueryToArray(req.query.userId);
+
+      if (!userIds && req.currentContext.userId) userIds = [req.currentContext.userId];


What is the reasoning for defaulting to searching the current user if no other IDs are provided?

kyle1morel · 2025-01-09T18:30:12Z

app/src/controllers/contact.ts

+  },
+  updateContact: async (req: Request<never, never, Contact, never>, res: Response, next: NextFunction) => {


Style: New line between functions

kyle1morel · 2025-01-09T18:41:39Z

app/src/db/migrations/20250107000000_018-contact-management.ts

@@ -0,0 +1,229 @@
+/* eslint-disable max-len */


Migration will have to be renamed before merging. An earlier PR, #231, has the 018 migration.

kyle1morel · 2025-01-09T18:48:06Z

app/src/db/migrations/20250107000000_018-contact-management.ts

+        // Add all navigator read only role mappings
+        await addResourceRoles(navigator_read_group_id[0].group_id, Resource.CONTACT, [Action.READ, Action.UPDATE]);
+
+


Style: Unnecessary new line

kyle1morel · 2025-01-09T18:48:10Z

app/src/db/migrations/20250107000000_018-contact-management.ts

+        // Add all admin role mappings
+        await addResourceRoles(admin_group_id[0].group_id, Resource.CONTACT, [Action.READ, Action.UPDATE]);
+
+


Style: Unnecessary new line

kyle1morel · 2025-01-10T00:48:25Z

frontend/src/locales/en-CA.json

@@ -129,5 +130,19 @@
    "projectLocationDescriptionCard": "Is there anything else you would like to tell us about this project's location? (optional)",
    "provincialPermitsCard": "Have you applied for any provincial permits for this project?",
    "investigatePermitsCard": "Select all provincially issued permits you think you might need (optional)"
+  },
+  "contactProfileView": {


Please alphabetize the top level keys as well.

kyle1morel · 2025-01-10T00:56:02Z

frontend/src/services/contactService.ts

+   * @function updateEnquiry
+   * @returns {Promise} An axios response
+   */
+  updateContact(contactId: string, data?: any) {


contactId is not necessary here. You can pull the path parameter from data.

oh right, missed that. thanks!

kyle1morel · 2025-01-10T00:56:38Z

frontend/src/views/contact/ContactProfileView.vue

+    const submitData: Contact = setEmptyStringsToNull(values);
+    const result = await contactService.updateContact(values.contactId, submitData);
+    if (result.status === 200) {
+      toast.success('Form saved');


Please add all new text to the locale file.

kyle1morel · 2025-01-10T00:57:56Z

frontend/src/views/contact/ContactProfileView.vue

+h3 {
+  margin-top: 1em;
+}
+:deep(.p-card-body) {
+  width: 35rem;
+  box-shadow: 0 0 0.2rem #036;
+  padding-bottom: 0;
+}
+.display-inline {
+  display: inline;
+}


Style: A newline should be present between classes.

done, thank you!

kyle1morel · 2025-01-10T01:00:32Z

frontend/src/views/contact/ContactProfileView.vue

+          <FormNavigationGuard />
+          <InputText
+            name="firstName"
+            :label="t('contactProfileView.firstName')"
+            :disabled="true"
+          />
+
+          <InputText
+            name="lastName"
+            :label="t('contactProfileView.lastName')"
+            :disabled="true"
+          />
+          <InputText
+            name="email"
+            :label="t('contactProfileView.email')"
+            :disabled="true"
+          />
+          <InputMask
+            name="phoneNumber"
+            mask="(999) 999-9999"
+            :label="t('contactProfileView.phone')"
+          />
+
+          <Dropdown
+            name="contactApplicantRelationship"
+            :label="t('contactProfileView.relationshipToProject')"
+            :bold="true"
+            :options="PROJECT_RELATIONSHIP_LIST"
+          />
+          <Dropdown
+            name="contactPreference"
+            :label="t('contactProfileView.preferredContact')"
+            :bold="true"
+            :options="CONTACT_PREFERENCE_LIST"
+          />
+


Style: Inconsistent newlines between components. In this instance, we probably want to remove them. Precedence in the application currently is to add a newline between major blocks, such as <Card />.

qhanson55 · 2025-01-14T16:39:51Z

app/src/controllers/contact.ts

+      const identityIds = mixedQueryToArray(req.query.identityId);
+
+      console.log('\n\n\nidentityIds>>>>>' + identityIds);
+      console.log('\n\n\ncontactIds>>>>>' + contactIds);


These console statements are needed?

removed! thanks

…tSearch type, migration for contact resource, updated - enquiry, submission controllers upsert calls, user service to create contact on login, renamed contacts validator

…actSearchParams type, contactService, tests, updated - HeaderMenu, en-CA, application enums, router, authzStore

github-advanced-security bot found potential problems Jan 7, 2025

View reviewed changes

app/src/controllers/contact.ts Dismissed Show dismissed Hide dismissed

sanjaytkbabu force-pushed the feature/contact-profile branch 2 times, most recently from 33733a1 to c25b259 Compare January 8, 2025 00:55

sanjaytkbabu closed this Jan 8, 2025

sanjaytkbabu reopened this Jan 8, 2025

sanjaytkbabu force-pushed the feature/contact-profile branch from c25b259 to fd1adca Compare January 8, 2025 01:09

sanjaytkbabu force-pushed the feature/contact-profile branch from 564c66e to a1317e1 Compare January 8, 2025 22:33

sanjaytkbabu marked this pull request as ready for review January 8, 2025 22:40

sanjaytkbabu requested review from kyle1morel, wilwong89 and qhanson55 as code owners January 8, 2025 22:40

sanjaytkbabu closed this Jan 8, 2025

sanjaytkbabu reopened this Jan 8, 2025

sanjaytkbabu force-pushed the feature/contact-profile branch from a1317e1 to 7853dca Compare January 8, 2025 23:49

sanjaytkbabu closed this Jan 8, 2025

sanjaytkbabu reopened this Jan 8, 2025

sanjaytkbabu force-pushed the feature/contact-profile branch 4 times, most recently from 42e02be to 8adf7e4 Compare January 9, 2025 22:02

sanjaytkbabu closed this Jan 9, 2025

sanjaytkbabu reopened this Jan 9, 2025

sanjaytkbabu force-pushed the feature/contact-profile branch 2 times, most recently from 79bb10b to 0cdbfe4 Compare January 10, 2025 00:00

sanjaytkbabu closed this Jan 10, 2025

sanjaytkbabu reopened this Jan 10, 2025

kyle1morel reviewed Jan 10, 2025

View reviewed changes

sanjaytkbabu force-pushed the feature/contact-profile branch 2 times, most recently from 2234eef to 704948c Compare January 10, 2025 23:24

qhanson55 reviewed Jan 14, 2025

View reviewed changes

sanjaytkbabu force-pushed the feature/contact-profile branch from 704948c to a1a1ec6 Compare January 15, 2025 00:57

sanjaytkbabu added 2 commits January 14, 2025 17:02

Contact management - backend changes: new - controller, route, contac…

7aa91a9

…tSearch type, migration for contact resource, updated - enquiry, submission controllers upsert calls, user service to create contact on login, renamed contacts validator

Contact management - frontend changes: new - contactProfileView, cont…

7eb5a35

…actSearchParams type, contactService, tests, updated - HeaderMenu, en-CA, application enums, router, authzStore

sanjaytkbabu force-pushed the feature/contact-profile branch from a1a1ec6 to 7eb5a35 Compare January 15, 2025 01:02

qhanson55 approved these changes Jan 15, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Proponent Contact Profile #235

Proponent Contact Profile #235

sanjaytkbabu commented Jan 7, 2025 •

edited

Loading

github-actions bot commented Jan 7, 2025 •

edited

Loading

github-actions bot commented Jan 7, 2025 •

edited

Loading

slhurley commented Jan 8, 2025

Subin1Doo commented Jan 8, 2025

sanjaytkbabu commented Jan 8, 2025

sanjaytkbabu commented Jan 8, 2025

github-actions bot commented Jan 10, 2025 •

edited

Loading

kyle1morel Jan 9, 2025

kyle1morel Jan 9, 2025

sanjaytkbabu Jan 10, 2025

kyle1morel Jan 9, 2025

sanjaytkbabu Jan 10, 2025

kyle1morel Jan 9, 2025

sanjaytkbabu Jan 10, 2025

kyle1morel Jan 9, 2025

sanjaytkbabu Jan 10, 2025

kyle1morel Jan 10, 2025

sanjaytkbabu Jan 10, 2025

kyle1morel Jan 10, 2025

sanjaytkbabu Jan 10, 2025

kyle1morel Jan 10, 2025

sanjaytkbabu Jan 10, 2025

kyle1morel Jan 10, 2025

sanjaytkbabu Jan 10, 2025

kyle1morel Jan 10, 2025

sanjaytkbabu Jan 10, 2025

qhanson55 Jan 14, 2025

sanjaytkbabu Jan 15, 2025

		},
		updateContact: async (req: Request<never, never, Contact, never>, res: Response, next: NextFunction) => {

		// Add all navigator read only role mappings
		await addResourceRoles(navigator_read_group_id[0].group_id, Resource.CONTACT, [Action.READ, Action.UPDATE]);

		// Add all admin role mappings
		await addResourceRoles(admin_group_id[0].group_id, Resource.CONTACT, [Action.READ, Action.UPDATE]);

Proponent Contact Profile #235

Are you sure you want to change the base?

Proponent Contact Profile #235

Conversation

sanjaytkbabu commented Jan 7, 2025 • edited Loading

Description

Types of changes

Checklist

Further comments

github-actions bot commented Jan 7, 2025 • edited Loading

Coverage Report (Frontend)

github-actions bot commented Jan 7, 2025 • edited Loading

Coverage Report (Application)

slhurley commented Jan 8, 2025

Subin1Doo commented Jan 8, 2025

sanjaytkbabu commented Jan 8, 2025

sanjaytkbabu commented Jan 8, 2025

github-actions bot commented Jan 10, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sanjaytkbabu commented Jan 7, 2025 •

edited

Loading

github-actions bot commented Jan 7, 2025 •

edited

Loading

github-actions bot commented Jan 7, 2025 •

edited

Loading

github-actions bot commented Jan 10, 2025 •

edited

Loading