Scrollbars classnames #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @bashkos - great stuff! However, my repo is just a fork of the main repo found at https://github.com/souhe/reactScrollbar. Your best bet is to put in a PR there... unfortunately it doesn't look like it's being well supported anymore. Still, hopefully someone will take the lead and create a fork off it & can re-use your commit. All the best! |
|
I know =) souhe#88 |
|
Ahhhh! You da man :) Sadly, I have enough repos to take care of myself! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases the best way to customize scrollbars is an class names. That's why I'm added 4 new props:
verticalContainerClassName;verticalScrollbarClassName;horizontalContainerClassName;horizontalScrollbarClassName.I'm also included classnames package for easier manipulation of class names. And wrote the relevant tests.