Skip to content

Commit

Permalink
Merge pull request #381 from ebmdatalab/fix-output-checking-rota-noti…
Browse files Browse the repository at this point in the history
…fication-title

fix header text - output checking rota notification
  • Loading branch information
inglesp authored Nov 10, 2023
2 parents a85d9cd + 7b7f270 commit cb712ad
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
10 changes: 8 additions & 2 deletions tests/test_outputchecking_rota.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,10 @@ def test_rota_report_on_monday(get_rota_data_from_sheet, freezer):
get_rota_data_from_sheet.return_value = list(csv.reader(f))
blocks = json.loads(report_rota())
assert blocks == [
{"text": {"text": "Tech support rota", "type": "plain_text"}, "type": "header"},
{
"text": {"text": "Output checking rota", "type": "plain_text"},
"type": "header",
},
{
"text": {
"text": "Lead reviewer this week: Louis Fisher (secondary: Colm Andrews)",
Expand All @@ -37,7 +40,10 @@ def test_rota_report_on_tuesday(get_rota_data_from_sheet, freezer):
get_rota_data_from_sheet.return_value = list(csv.reader(f))
blocks = json.loads(report_rota())
assert blocks == [
{"text": {"text": "Tech support rota", "type": "plain_text"}, "type": "header"},
{
"text": {"text": "Output checking rota", "type": "plain_text"},
"type": "header",
},
{
"text": {
"text": "Lead reviewer next week: Jon Massey (secondary: Lisa Hopcroft)",
Expand Down
2 changes: 1 addition & 1 deletion workspace/outputchecking/jobs.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def report_rota():
"type": "header",
"text": {
"type": "plain_text",
"text": "Tech support rota",
"text": "Output checking rota",
},
},
]
Expand Down

0 comments on commit cb712ad

Please sign in to comment.