Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix header text - output checking rota notification #381

Merged
merged 2 commits into from
Nov 10, 2023
Merged

fix header text - output checking rota notification #381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e97115a
fix header text
LFISHER7 Nov 10, 2023
7b7f270
Update tests
LFISHER7 Nov 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions tests/test_outputchecking_rota.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,10 @@ def test_rota_report_on_monday(get_rota_data_from_sheet, freezer):
get_rota_data_from_sheet.return_value = list(csv.reader(f))
blocks = json.loads(report_rota())
assert blocks == [
{"text": {"text": "Tech support rota", "type": "plain_text"}, "type": "header"},
{
"text": {"text": "Output checking rota", "type": "plain_text"},
"type": "header",
},
{
"text": {
"text": "Lead reviewer this week: Louis Fisher (secondary: Colm Andrews)",
Expand All @@ -37,7 +40,10 @@ def test_rota_report_on_tuesday(get_rota_data_from_sheet, freezer):
get_rota_data_from_sheet.return_value = list(csv.reader(f))
blocks = json.loads(report_rota())
assert blocks == [
{"text": {"text": "Tech support rota", "type": "plain_text"}, "type": "header"},
{
"text": {"text": "Output checking rota", "type": "plain_text"},
"type": "header",
},
{
"text": {
"text": "Lead reviewer next week: Jon Massey (secondary: Lisa Hopcroft)",
Expand Down
2 changes: 1 addition & 1 deletion workspace/outputchecking/jobs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def report_rota():
"type": "header",
"text": {
"type": "plain_text",
"text": "Tech support rota",
"text": "Output checking rota",
},
},
]
Expand Down