Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run webserver with gunicorn #389

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Run webserver with gunicorn #389

merged 1 commit into from
Jan 9, 2024

Conversation

rebkwok
Copy link
Contributor

@rebkwok rebkwok commented Jan 8, 2024

The webserver in BennettBot is a Flask app; as per flask docs using app.run is intended for development only. As we've now moved to the new dokku app, update to run with gunicorn as well.

Copy link
Contributor

@inglesp inglesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Would be nice to have an indication in the PR of why we're doing this now.

@rebkwok
Copy link
Contributor Author

rebkwok commented Jan 9, 2024

Looks good. Would be nice to have an indication in the PR of why we're doing this now.

Because I keep seeing the "do not use this in production" message in the dokku deploys?

@rebkwok rebkwok merged commit e01745c into main Jan 9, 2024
6 checks passed
@rebkwok rebkwok deleted the gunicorn branch January 9, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants