Parametrize threshold #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the Slack request to specify the threshold rather than hard-coding it. We may fine-tune this depending on how much output we get and what proves most useful to users. This makes it easier to do that experimentation, change Slack reminders etc. I'll update the playbook with the current threshold and rationale. That'll be a separate PR as it's a separate repo (team-manual). As discussed in Slack: https://bennettoxford.slack.com/archives/C069SADHP1Q/p1736434022622129?thread_ts=1736427127.238419&cid=C069SADHP1Q
It wasn't as clear and useful as it could be. User and repo are most important for working out if it needs responding to, so put them first. Include "Deletion: " text before the datetime to make it clear to what it refers. As discussed in Slack: https://bennettoxford.slack.com/archives/C069SADHP1Q/p1736765655458669?thread_ts=1736427127.238419&cid=C069SADHP1Q
Jongmassey
approved these changes
Jan 13, 2025
|
Thanks for the review, Jon.
That's correct. I don't think Iain had time as he was originally implementing it before moving team, and I didn't think it seemed like a big enough change to be worth writing tests. If the workspace needed more significant work it could be worth writing some, but I'll leave that to someone to decide when they come to do such work. I don't think it's worth an Issue in isolation. Let me know if you disagree. |
mikerkelly
deleted the
mikerkelly/workspace/codespaces/parametrize-threshold
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the Slack request to specify the threshold rather than hard-coding it. We
may fine-tune this depending on how much output we get and what proves most
useful to users. This makes it easier to do that experimentation, change Slack
reminders etc.
I'll update the playbook with the current threshold and rationale. That'll be a
separate PR as it's a separate repo (team-manual).
As discussed in Slack:
https://bennettoxford.slack.com/archives/C069SADHP1Q/p1736434022622129?thread_ts=1736427127.238419&cid=C069SADHP1Q