fix: clause menu spinner position and title sticky

betagouv · Jan 10, 2025 · bfc5811 · bfc5811
1 parent 50d0d42
commit bfc5811
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/packages/frontend/src/features/menu/ClauseMenu.tsx b/packages/frontend/src/features/menu/ClauseMenu.tsx
@@ -28,7 +28,12 @@ export const ClauseMenu = ({ isNational, ...props }: { isNational: boolean } & M
       .selectAll(),
   );
 
-  if (clausesQuery.isLoading) return <Spinner />;
+  if (clausesQuery.isLoading)
+    return (
+      <styled.div h="100%">
+        <Spinner />
+      </styled.div>
+    );
 
   if (isNational)
     return (

diff --git a/packages/frontend/src/features/menu/MenuButton.tsx b/packages/frontend/src/features/menu/MenuButton.tsx
@@ -93,8 +93,8 @@ export const MenuButton = () => {
 };
 
 const modalContents: Record<MenuStates, (props: ModalContentProps) => ReactNode> = {
-  main: (props) => <MenuActions />,
-  help: (props) => <HelpMenu />,
+  main: (_props) => <MenuActions />,
+  help: (_props) => <HelpMenu />,
   clausesDepartementales: (props) => <ClauseMenu isNational={false} {...props} />,
   clausesNationales: (props) => <ClauseMenu isNational {...props} />,
   share: (props) => <ShareReport {...props} />,

diff --git a/packages/frontend/src/features/menu/MenuTitle.tsx b/packages/frontend/src/features/menu/MenuTitle.tsx
@@ -19,8 +19,8 @@ export const MenuTitle = ({
   <>
     <Flex
       zIndex="5"
-      position={{ base: "sticky", lg: "unset" }}
-      top={{ base: "-1px", lg: "unset" }}
+      position={{ base: "sticky", lg: "sticky" }}
+      top={{ base: "0", lg: "0" }}
       justifyContent="space-between"
       alignItems="center"
       w="100%"