Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 7.4.2 #441

Merged
merged 28 commits into from
Dec 6, 2023
Merged

Release 7.4.2 #441

merged 28 commits into from
Dec 6, 2023

Conversation

kayhantolga
Copy link
Member

No description provided.

belaszalontai and others added 23 commits November 13, 2023 14:32
Merge Origin to my master
https://platform.openai.com/docs/api-reference/chat/object

<quote>
This fingerprint represents the backend configuration that the model runs with.

Can be used in conjunction with the seed request parameter to understand when backend changes have been made that might impact determinism.
</quote>
…ge response messages.

Mark the old function api as Obsolete.
Added playground tests to test the new function calling and also get the streaming function calling example working (in a messy way).
Minor docs changes for image creation parameter Quality
Add missing revised_prompt property to ImageDataResult model
Add system_fingerprint to the ChatCompletionCreateResponse class as per:
Support has been added for passing as object to the function field in the tool.
…es, updated playground regarding changes. Updated some documentation.
Add new tool choices to the ChatCompletionCreateRequest and ChatMessa…
@kayhantolga kayhantolga added this to the 7.4.2 milestone Dec 5, 2023
@kayhantolga kayhantolga self-assigned this Dec 5, 2023
@kayhantolga
Copy link
Member Author

@belaszalontai @shanepowell and others, please take a look before merging while I focus on the final details. Let me know if you are unhappy with any changes or have any doubts.

@shanepowell
Copy link
Contributor

It looks fine to me except that due to the change you did the RunChatFunctionCallTest and RunChatFunctionCallTestAsStream tests fail now.

The lines in both functions:

                Tools = new List<ToolDefinition> { new() { Function = fn1 }, new() { Function = fn2 }, new() { Function = fn3 }, new() { Function = fn4 }, new() { Function = fn4 } },

Needs to change to:

                Tools = new List<ToolDefinition> { new() { Type = StaticValues.CompletionStatics.ToolType.Function, Function = fn1 }, new() { Type = StaticValues.CompletionStatics.ToolType.Function, Function = fn2 }, new() { Type = StaticValues.CompletionStatics.ToolType.Function, Function = fn3 }, new() { Type = StaticValues.CompletionStatics.ToolType.Function, Function = fn4 }, new() { Type = StaticValues.CompletionStatics.ToolType.Function, Function = fn4 } },

Writing a nice helper method like ToolChoice.FunctionChoice for ToolDefinition would be nice.
e.g.

public class ToolDefinition
{
    public static ToolDefinition FunctionTool(FunctionDefinition function) =>new()
    {
        Type = StaticValues.CompletionStatics.ToolType.Function,
        Function = function
    };

Then we could write:

                Tools = new List<ToolDefinition> { ToolDefinition.FunctionTool(fn1), ToolDefinition.FunctionTool(fn2), ToolDefinition.FunctionTool(fn3), ToolDefinition.FunctionTool(fn4) },

@kayhantolga
Copy link
Member Author

#444 @shanepowell

@kayhantolga kayhantolga marked this pull request as ready for review December 6, 2023 21:25
@kayhantolga kayhantolga merged commit 3747353 into master Dec 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants