Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: discussion feedback #1

Merged
merged 4 commits into from
Dec 3, 2024
Merged

feat: discussion feedback #1

merged 4 commits into from
Dec 3, 2024

Conversation

sakulstra
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

🔮 Coverage report
File Line Coverage Function Coverage Branch Coverage
src/GhoDirectMinter.sol ${\color{green}100\%}$
$22 / 22$
 ${\color{green}100\%}$
$5 / 5$
 ${\color{red}50\%}$
$1 / 2$
src/proposals/LidoGHOListing.sol ${\color{green}100\%}$
$12 / 12$
 ${\color{red}66.67\%}$
$2 / 3$
LidoGHOListing.newListings 		${\color{green}100\%}$
$0 / 0$

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

🔧 Build logs 
Compiling 115 files with Solc 0.8.28
installing solc version "0.8.28"
Successfully installed solc 0.8.28
Solc 0.8.28 finished in 2.66s
Compiler run successful!
| Contract                            | Runtime Size (B) | Initcode Size (B) | Runtime Margin (B) | Initcode Margin (B) |
|-------------------------------------|------------------|-------------------|--------------------|---------------------|
| AaveV3Ethereum                      |               85 |               135 |             24,491 |              49,017 |
| AaveV3EthereumAssets                |               85 |               135 |             24,491 |              49,017 |
| AaveV3EthereumEModes                |               85 |               135 |             24,491 |              49,017 |
| AaveV3EthereumExternalLibraries     |               85 |               135 |             24,491 |              49,017 |
| AaveV3EthereumLido                  |               85 |               135 |             24,491 |              49,017 |
| AaveV3EthereumLidoAssets            |               85 |               135 |             24,491 |              49,017 |
| AaveV3EthereumLidoEModes            |               85 |               135 |             24,491 |              49,017 |
| AaveV3EthereumLidoExternalLibraries |               85 |               135 |             24,491 |              49,017 |
| Address                             |               85 |               135 |             24,491 |              49,017 |
| ChainHelpers                        |               85 |               135 |             24,491 |              49,017 |
| ChainIds                            |               85 |               135 |             24,491 |              49,017 |
| ConfiguratorInputTypes              |               85 |               135 |             24,491 |              49,017 |
| Create2Utils                        |              162 |               212 |             24,414 |              48,940 |
| Create2UtilsZkSync                  |              145 |               195 |             24,431 |              48,957 |
| DataTypes                           |               85 |               135 |             24,491 |              49,017 |
| ERC1967Proxy                        |              163 |               976 |             24,413 |              48,176 |
| ERC1967Utils                        |               85 |               135 |             24,491 |              49,017 |
| EngineFlags                         |               85 |               135 |             24,491 |              49,017 |
| Errors                              |            4,671 |             4,723 |             19,905 |              44,429 |
| GhoDirectMinter                     |            4,555 |             6,026 |             20,021 |              43,126 |
| GovV3Helpers                        |            2,384 |             2,436 |             22,192 |              46,716 |
| GovV3StorageHelpers                 |               85 |               135 |             24,491 |              49,017 |
| GovernanceV3Arbitrum                |               85 |               135 |             24,491 |              49,017 |
| GovernanceV3Avalanche               |               85 |               135 |             24,491 |              49,017 |
| GovernanceV3BNB                     |               85 |               135 |             24,491 |              49,017 |
| GovernanceV3Base                    |               85 |               135 |             24,491 |              49,017 |
| GovernanceV3Ethereum                |               85 |               135 |             24,491 |              49,017 |
| GovernanceV3Gnosis                  |               85 |               135 |             24,491 |              49,017 |
| GovernanceV3Metis                   |               85 |               135 |             24,491 |              49,017 |
| GovernanceV3Optimism                |               85 |               135 |             24,491 |              49,017 |
| GovernanceV3Polygon                 |               85 |               135 |             24,491 |              49,017 |
| GovernanceV3PolygonZkEvm            |               85 |               135 |             24,491 |              49,017 |
| GovernanceV3Scroll                  |               85 |               135 |             24,491 |              49,017 |
| GovernanceV3ZkSync                  |               85 |               135 |             24,491 |              49,017 |
| IpfsUtils                           |               85 |               135 |             24,491 |              49,017 |
| LidoGHOListing                      |           10,950 |            11,128 |             13,626 |              38,024 |
| MiscEthereum                        |               85 |               135 |             24,491 |              49,017 |
| PayloadsControllerUtils             |               85 |               135 |             24,491 |              49,017 |
| ProxyAdmin                          |            1,018 |             1,254 |             23,558 |              47,898 |
| ProxyHelpers                        |               85 |               135 |             24,491 |              49,017 |
| ReserveConfiguration                |              169 |               219 |             24,407 |              48,933 |
| SafeERC20                           |               85 |               135 |             24,491 |              49,017 |
| StorageHelpers                      |               85 |               135 |             24,491 |              49,017 |
| StorageSlot                         |               85 |               135 |             24,491 |              49,017 |
| TestNetChainIds                     |               85 |               135 |             24,491 |              49,017 |
| TransparentUpgradeableProxy         |            1,115 |             2,206 |             23,461 |              46,946 |
| WadRayMath                          |               85 |               135 |             24,491 |              49,017 |

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

⛽ Gas report

TransparentUpgradeableProxy

  • size: 0 / 49152
Method min mean median max calls
COLLECTOR() ↑0.15%663 ↑0.15%663 ↑0.15%663 ↑0.15%663 1
GHO_A_TOKEN() ↑6.8%706 ↑6.8%706 ↑6.8%706 ↑6.8%706 7
mintAndSupply(uint256) ↑7.9%31000 ↑20%222937 ↑20%260886 ↑21%263117 6
withdrawAndBurn(uint256) ↑7.9%30933 ↑0.48%145718 158229 ↑1.4%160472 10

GhoDirectMinter

  • size: 0 / 49152
Method min mean median max calls
COLLECTOR() 227 227 227 227 1
GHO_A_TOKEN() 270 270 270 270 7
initialize(address,address) 72313 72313 72313 72313 7
mintAndSupply(uint256) 4853 221735 212750 279457 13
transferExcessToTreasury() 116231 116231 116231 116231 1
withdrawAndBurn(uint256) 4786 150373 166305 168512 10

LidoGHOListing

  • size: ↑13%11160 / 49152
Method min mean median max calls
execute() ↑7.4%3578285 ↑7.4%3578285 ↑7.4%3578285 ↑7.4%3578285 7

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

🌈 Test Results 
No files changed, compilation skipped

Ran 7 tests for test/Lido_GhoDirectMinter.t.sol:Lido_GHODirectMinter_Test
[PASS] test_mintAndSupply_council(uint256) (runs: 256, μ: 277610, ~: 277339)
[PASS] test_mintAndSupply_owner(uint256) (runs: 256, μ: 275395, ~: 275109)
[PASS] test_mintAndSupply_rando() (gas: 18205)
[PASS] test_transferExcessToTreasury() (gas: 864730)
Logs:
  Bound result 1000000000000000000000

[PASS] test_withdrawAndBurn_council(uint256,uint256) (runs: 256, μ: 316268, ~: 316257)
[PASS] test_withdrawAndBurn_owner(uint256,uint256) (runs: 256, μ: 312938, ~: 312920)
[PASS] test_withdrawAndBurn_rando() (gas: 18105)
Suite result: ok. 7 passed; 0 failed; 0 skipped; finished in 605.17ms (1.60s CPU time)

Ran 1 test suite in 608.36ms (605.17ms CPU time): 7 tests passed, 0 failed, 0 skipped (7 total tests)

@sakulstra sakulstra force-pushed the feat/discussion-feedback branch from 25eb187 to 5c22d96 Compare November 29, 2024 10:00
@sakulstra sakulstra merged commit bc91039 into main Dec 3, 2024
2 checks passed
@sakulstra sakulstra deleted the feat/discussion-feedback branch December 3, 2024 07:37
sakulstra added a commit that referenced this pull request Dec 3, 2024
@sakulstra
feat: discussion feedback (#1)
c7b299f 
fix: move date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sakulstra