feat: add new emode category via generator #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rozengarden
pushed a commit
to Rozengarden/aave-proposals-v3
that referenced
this pull request
Nov 2, 2023
* fix: typo * chore: fix text * feat: add new e-mode category via the generator * fix: KEEP_CURRENT_STRING * fix: emode label * fix: generator booleanSelect ENABLED DISABLED * fix: collateral updates code artifacts * refactor: eModesUpdates * fix: lint * fix: generator shadows an existing priceFeedsUpdates var * fix: v3 config engine rates import generator * fix: v2 v3 engine rates import generator * forge install: aave-address-book v2.8.0 * chore: update address book * fix: use correct contract an asset listings - targets bgd-labs#3 * fix: some minor patches * fix: remapping * chore: some cleanup * fix: do not revert when no e-mode category exists on the pool * fix: makefile * fix: eModesSelect * fix: typo * fix: asset listing approve before supply and collector funds * fix: use forceApprove on generator for assetListing * chore: update aave helpers * fix: test * fix: typo --------- Co-authored-by: sakulstra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Update address book lib after PR merge of emode-id to uint8
Fix the generator to use
forceApprove()and fix imports accordinglysome generator fixes
currently via the generator we can only update the existing emode category, so now we can create a new emode category via the generator also