Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add update.py semi-automatic release crawler #1
[WIP] Add update.py semi-automatic release crawler #1
Changes from 3 commits
c82d748
9e95510
ceabc10
85b28fa
17426d6
f8d1237
dd743ee
f78da21
baa6dd9
9028e80
94d05bf
ccd763e
b391051
ba95f26
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only BIDS-related item: why not base directly on,e.g., ubuntu?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea why this is the base image. Is it containing something that BIDS-Apps expect?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't remember now but given the
--skip-bids-validator
flag, I assume that a BIDS-App would by default validate the BIDS input and therefore expectbids-validator
to be available.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bids/base_validator
is ubuntu with bids-validator installed. But it seems to be very outdated as well: https://github.com/BIDS-Apps/base_validator/blob/master/DockerfileThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That one could probably be based on
node:current-slim
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
bids/base_validator
is meant to be a base image on which to base BIDS app thennode:current-slim
would probably not be first choice. Even fmriprep is not based onbids/base_validator
but a very specific image (ubuntu:xenial-20200114
). Not sure one can impose an base, thereforebids/base_validator
andbids/matlab-compiler-runtime
are more examples than base images?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps. 🤷♂️ I'll ask about this in an upcoming meeting with other BIDS folks who may know.