Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: do not sync biome.lspBin by default #100

Merged
merged 1 commit into from
Jan 28, 2024
Merged

chore: do not sync biome.lspBin by default #100

merged 1 commit into from
Jan 28, 2024

Conversation

Malix-Labs
Copy link
Contributor

No description provided.

@nhedger
Copy link
Member

nhedger commented Jan 28, 2024

What is the rationale behind this change?

As far as I know, we haven't had any complaints regarding the syncing of this option.

Not to say I'm against it; I'd just like to understand.

@Malix-Labs
Copy link
Contributor Author

@nhedger

Hello Nicolas!

It is a common thing for all the vscode extensions i've seen so far to have binary path configuration contributions having ignoreSync, the rationale being that the binary path isn't guaranteed to be the same between devices.

@nhedger
Copy link
Member

nhedger commented Jan 28, 2024

Thanks for the clarification.

If a user wanted to sync this setting anyway, is there a way for him to force it?

@Malix-Labs
Copy link
Contributor Author

@nhedger
Absolutely!
ignoreSync is just to make it default (documentation)
image

@nhedger
Copy link
Member

nhedger commented Jan 28, 2024

Cool, thanks!

@nhedger nhedger changed the title chore: add "ignoreSync" for "biome.lspBin" setting chore: do not sync biome.lspBin by default Jan 28, 2024
@nhedger nhedger merged commit cc0624c into biomejs:main Jan 28, 2024
3 checks passed
@Malix-Labs Malix-Labs deleted the patch-2 branch January 28, 2024 18:27
@Malix-Labs
Copy link
Contributor Author

I couldn't find the difference between ignoreSync and the "machine" scope, so I asked for vscode's clarification (see microsoft/vscode-docs#7638)

I might publish an update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants