making images responsive #825
Conversation
DanDaManTran
deleted the
LD-204-fix-bug-in-academy-where-images-can-overflow-the-main-content-in-academy-they-should-be-responsive
branch
| @@ -81,7 +81,8 @@ Create routes for the `HomeComponent` and `RestaurantComponent`. When the route | |||
| Notice that you will be able to click the **Choose a Restaurant** button | |||
| after implementing the solution: | |||
|
|
|||
|  | |||
| <img alt="Choose a restaurant routing." src="../static/img/angular/4-adding-routing/after.gif" | |||
| style="border: solid 1px black;" width="90%"/> | |||
There was a problem hiding this comment.
Why was this set to 90% and not 100%?
There was a problem hiding this comment.
hmm I thought I set the width with similar widths in Angular. I guess not.
There was a problem hiding this comment.
I added requirements to the issue: https://bitovi.atlassian.net/browse/LD-204
Please let me know if you have any questions, I’m happy to talk through it more.
| @@ -18,7 +18,7 @@ In this section, we will: | |||
|
|
|||
| We want to have a component to display individual restaurants details, and want the path to be nested under the restaurants path. | |||
|
|
|||
| <img alt="Screenshot of the Place My Order app with a nested route, displaying the “/restaurants/lettuce-shack” URL in the browser’s address bar." src="../static/img/react-vite/10-nested-routes/01-solution.png" style="max-width: 735px;"/> | |||
| <img alt="Screenshot of the Place My Order app with a nested route, displaying the “/restaurants/lettuce-shack” URL in the browser’s address bar." src="../static/img/react-vite/10-nested-routes/01-solution.png" style="max-width: 640px;"/> | |||
There was a problem hiding this comment.
What’s this value based on? I just checked the image and it should be a max of 735px wide.
There was a problem hiding this comment.
735px image was overlapping with the side bar. 640px was used in /src/react-vite/03-intro-to-jsx/intro-to-jsx.md so I went with that.
There was a problem hiding this comment.
Let’s move these values out of the style attribute and specify the height and width attributes on the image: https://bitovi.atlassian.net/browse/LD-204
No description provided.