Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-12571][PM-13807] Add/Edit Folder Dialog #12487

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

nick-livefront
Copy link
Collaborator

@nick-livefront nick-livefront commented Dec 19, 2024

🎟️ Tracking

PM-12571
PM-13807

📔 Objective

  • Moves AddEditFolderDialogComponent to @bitwarden/angular/vault/components so it can be used by both the browser and web
    • Adds AddEditFolderDialogResult enum so the web vault can redirect when a folder is deleted.
  • Integrates the AddEditFolderDialogComponent to the web vault.
  • Adds add/edit copy to the web messages file
  • Fixes strict types on touched files
  • Fixes missing hover border on delete icon button (PM-13807)

📸 Screenshots

Add/Edit/Delete folder on the web
Screen.Recording.2024-12-19.at.2.23.10.PM.mov

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@nick-livefront nick-livefront requested a review from a team as a code owner December 19, 2024 20:33
Copy link
Contributor

github-actions bot commented Dec 19, 2024

Logo
Checkmarx One – Scan Summary & Details1787b9a5-10f4-4cee-9313-321ff402b3c3

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Client_Privacy_Violation /apps/cli/src/commands/get.command.ts: 162 Attack Vector
MEDIUM Client_Privacy_Violation /apps/cli/src/vault/models/cipher.response.ts: 34 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM Client_Privacy_Violation /apps/cli/src/commands/get.command.ts: 331

Copy link
Member

@shane-melton shane-melton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a few non-blocking suggestions/nits and one file move request.

shane-melton
shane-melton previously approved these changes Jan 9, 2025
Copy link
Member

@shane-melton shane-melton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice work!

@shane-melton
Copy link
Member

I believe the failing tests should start working again after a merge with main. (we had some flaky date based tests that needed to be fixed for the new year)

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 34.13%. Comparing base (b8f57f3) to head (7da6bf9).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../src/app/vault/individual-vault/vault.component.ts 0.00% 7 Missing ⚠️
...-folder-dialog/add-edit-folder-dialog.component.ts 76.47% 1 Missing and 3 partials ⚠️
...ew-item-dropdown/new-item-dropdown-v2.component.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12487   +/-   ##
=======================================
  Coverage   34.13%   34.13%           
=======================================
  Files        2936     2936           
  Lines       90433    90441    +8     
  Branches    16989    16990    +1     
=======================================
+ Hits        30869    30873    +4     
- Misses      57107    57109    +2     
- Partials     2457     2459    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nick-livefront
Copy link
Collaborator Author

Fixed conflicts from main, @shane-melton re-requesting review!

shane-melton
shane-melton previously approved these changes Jan 9, 2025
@nick-livefront
Copy link
Collaborator Author

@shane-melton @gbubemismith Brad realized that the full folder name was not being populated in the web vault. This was caused by the folder name being broken down into parts to be shown in the nested format.

I added the fullName property to the FolderFilter type so the edit dialog can reference the full name rather than just the last part.

706c388, b16fe41, 70bd316

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants