-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-12571][PM-13807] Add/Edit Folder Dialog #12487
base: main
Are you sure you want to change the base?
Conversation
…can be consumed by other platforms
New Issues
Fixed Issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a few non-blocking suggestions/nits and one file move request.
libs/angular/src/vault/components/add-edit-folder-dialog/add-edit-folder-dialog.component.ts
Outdated
Show resolved
Hide resolved
libs/angular/src/vault/components/add-edit-folder-dialog/add-edit-folder-dialog.component.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, nice work!
I believe the failing tests should start working again after a merge with |
…t/pm-12571/folder-dialog
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #12487 +/- ##
=======================================
Coverage 34.13% 34.13%
=======================================
Files 2936 2936
Lines 90433 90441 +8
Branches 16989 16990 +1
=======================================
+ Hits 30869 30873 +4
- Misses 57107 57109 +2
- Partials 2457 2459 +2 ☔ View full report in Codecov by Sentry. |
Fixed conflicts from main, @shane-melton re-requesting review! |
@shane-melton @gbubemismith Brad realized that the full folder name was not being populated in the web vault. This was caused by the folder name being broken down into parts to be shown in the nested format. I added the |
🎟️ Tracking
PM-12571
PM-13807
📔 Objective
AddEditFolderDialogComponent
to@bitwarden/angular/vault/components
so it can be used by both the browser and webAddEditFolderDialogResult
enum so the web vault can redirect when a folder is deleted.AddEditFolderDialogComponent
to the web vault.📸 Screenshots
Screen.Recording.2024-12-19.at.2.23.10.PM.mov
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes