Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-12047] Remove usage of ActiveUserState from cipher.service #12814

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

gbubemismith
Copy link
Member

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsad48c466-2f62-4492-82c5-7a5565d72dad

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Client_Privacy_Violation /apps/cli/src/commands/get.command.ts: 245 Attack Vector
MEDIUM Client_Privacy_Violation /apps/cli/src/commands/get.command.ts: 145 Attack Vector
MEDIUM Client_Privacy_Violation /apps/cli/src/commands/get.command.ts: 147 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/background/overlay.background.ts: 416 Attack Vector
MEDIUM Client_Privacy_Violation /apps/cli/src/commands/get.command.ts: 125 Attack Vector
MEDIUM Client_Privacy_Violation /apps/cli/src/commands/get.command.ts: 121 Attack Vector
MEDIUM Client_Privacy_Violation /libs/angular/src/vault/components/add-edit.component.ts: 758 Attack Vector
MEDIUM Client_Privacy_Violation /apps/cli/src/commands/get.command.ts: 57 Attack Vector
MEDIUM Client_Privacy_Violation /apps/cli/src/commands/get.command.ts: 57 Attack Vector
MEDIUM Client_Privacy_Violation /apps/cli/src/vault.program.ts: 392 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault/vault-filter.component.ts: 441 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault/vault-filter.component.ts: 441 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault/vault-filter.component.ts: 441 Attack Vector
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/vault.component.ts: 298 Attack Vector
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/vault.component.ts: 298 Attack Vector
MEDIUM Client_Privacy_Violation /apps/cli/src/oss-serve-configurator.ts: 132 Attack Vector
MEDIUM Client_Privacy_Violation /apps/cli/src/commands/get.command.ts: 125 Attack Vector
MEDIUM Client_Privacy_Violation /apps/cli/src/commands/get.command.ts: 125 Attack Vector
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/vault.component.ts: 305 Attack Vector
MEDIUM Client_Privacy_Violation /apps/cli/src/commands/get.command.ts: 131 Attack Vector
MEDIUM Client_Privacy_Violation /apps/cli/src/commands/get.command.ts: 131 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault/vault-filter.component.ts: 270 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault/vault-filter.component.ts: 270 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault/vault-filter.component.ts: 270 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault/vault-filter.component.ts: 253 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault/vault-filter.component.ts: 253 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault/vault-filter.component.ts: 253 Attack Vector
MEDIUM Client_Privacy_Violation /apps/cli/src/commands/get.command.ts: 115 Attack Vector
MEDIUM Client_Privacy_Violation /apps/cli/src/commands/get.command.ts: 115 Attack Vector
MEDIUM Client_Privacy_Violation /apps/cli/src/admin-console/commands/share.command.ts: 14 Attack Vector
MEDIUM Client_Privacy_Violation /libs/angular/src/vault/components/add-edit.component.ts: 754 Attack Vector
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/attachments-v2.component.html: 8 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault/vault-filter.component.ts: 264 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault/vault-filter.component.ts: 264 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault/vault-filter.component.ts: 264 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault/vault-filter.component.ts: 248 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault/vault-filter.component.ts: 248 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault/vault-filter.component.ts: 248 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault/vault-filter.component.ts: 55 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault/vault-filter.component.ts: 55 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault/vault-filter.component.ts: 55 Attack Vector
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/vault.component.ts: 1323 Attack Vector
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/vault.component.ts: 1323 Attack Vector
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/vault.component.ts: 1323 Attack Vector
MEDIUM Client_Privacy_Violation /libs/common/src/services/event/event-collection.service.ts: 88 Attack Vector
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/org-vault/services/admin-console-cipher-form-config.service.ts: 64 Attack Vector
MEDIUM Client_Privacy_Violation /libs/vault/src/cipher-form/services/default-cipher-form-config.service.ts: 41 Attack Vector
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/attachments-v2.component.html: 8 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/background/notification.background.ts: 551 Attack Vector
MEDIUM Client_Privacy_Violation /apps/cli/src/commands/get.command.ts: 334 Attack Vector
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/components/vault-item-dialog/vault-item-dialog.component.ts: 276 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/popup/fido2/fido2.component.ts: 216 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/popup/fido2/fido2-v1.component.ts: 173 Attack Vector
MEDIUM Client_Privacy_Violation /libs/common/src/platform/services/fido2/fido2-authenticator.service.ts: 137 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault-v2/view-v2/view-v2.component.ts: 125 Attack Vector
MEDIUM Client_Privacy_Violation /libs/vault/src/cipher-form/services/default-cipher-form-config.service.ts: 65 Attack Vector
MEDIUM Client_Privacy_Violation /apps/cli/src/admin-console/commands/share.command.ts: 61 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault-v2/vault-password-history-v2/vault-password-history-v2.component.ts: 48 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault-v2/attachments/open-attachments/open-attachments.component.ts: 36 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault-v2/attachments/open-attachments/open-attachments.component.ts: 34 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/popup/fido2/fido2.component.ts: 237 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/popup/fido2/fido2-v1.component.ts: 193 Attack Vector
MEDIUM Client_Privacy_Violation /libs/vault/src/cipher-form/components/attachments/cipher-attachments.component.ts: 82 Attack Vector
MEDIUM Client_Privacy_Violation /libs/angular/src/vault/components/view.component.ts: 51 Attack Vector
MEDIUM Client_Privacy_Violation /libs/angular/src/vault/components/add-edit.component.ts: 50 Attack Vector
MEDIUM Client_Privacy_Violation /libs/angular/src/vault/components/attachments.component.ts: 27 Attack Vector
MEDIUM Client_Privacy_Violation /libs/angular/src/admin-console/components/collections.component.ts: 21 Attack Vector
MEDIUM Client_Privacy_Violation /libs/angular/src/components/share.component.ts: 21 Attack Vector
MEDIUM Client_Privacy_Violation /libs/angular/src/components/share.component.ts: 21 Attack Vector
MEDIUM Client_Privacy_Violation /libs/angular/src/vault/components/password-history.component.ts: 14 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault/attachments.component.html: 25 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault/attachments.component.html: 25 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/cipher-row.component.ts: 11 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/cipher-row.component.ts: 11 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault/password-history.component.html: 18 Attack Vector
LOW Client_DOM_Open_Redirect /apps/browser/src/vault/popup/components/vault/password-history.component.ts: 23 Attack Vector
LOW Client_DOM_Open_Redirect /apps/browser/src/vault/popup/components/vault/attachments.component.ts: 37 Attack Vector
LOW Client_JQuery_Deprecated_Symbols /apps/web/src/app/tools/reports/pages/weak-passwords-report.component.ts: 94 Attack Vector
LOW Client_JQuery_Deprecated_Symbols /apps/web/src/app/tools/reports/pages/weak-passwords-report.component.ts: 87 Attack Vector
LOW Client_JQuery_Deprecated_Symbols /apps/browser/src/autofill/background/overlay.background.ts: 724 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM Client_Privacy_Violation /libs/vault/src/components/decryption-failure-dialog/decryption-failure-dialog.component.html: 17
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/background/overlay.background.ts: 411
MEDIUM Client_Privacy_Violation /apps/cli/src/commands/get.command.ts: 121
MEDIUM Client_Privacy_Violation /apps/cli/src/commands/get.command.ts: 125
MEDIUM Client_Privacy_Violation /apps/cli/src/commands/get.command.ts: 147
MEDIUM Client_Privacy_Violation /apps/cli/src/commands/get.command.ts: 145
MEDIUM Client_Privacy_Violation /apps/cli/src/commands/get.command.ts: 243
MEDIUM Client_Privacy_Violation /apps/cli/src/commands/get.command.ts: 125
MEDIUM Client_Privacy_Violation /apps/cli/src/commands/get.command.ts: 125
MEDIUM Client_Privacy_Violation /apps/cli/src/commands/get.command.ts: 57
MEDIUM Client_Privacy_Violation /apps/cli/src/commands/get.command.ts: 57
MEDIUM Client_Privacy_Violation /libs/angular/src/vault/components/add-edit.component.ts: 770
MEDIUM Client_Privacy_Violation /apps/cli/src/commands/get.command.ts: 331
MEDIUM Client_Privacy_Violation /libs/angular/src/vault/components/add-edit.component.ts: 766
MEDIUM Client_Privacy_Violation /apps/cli/src/commands/get.command.ts: 115
MEDIUM Client_Privacy_Violation /apps/cli/src/commands/get.command.ts: 115
MEDIUM Client_Privacy_Violation /apps/cli/src/commands/get.command.ts: 131
MEDIUM Client_Privacy_Violation /apps/cli/src/commands/get.command.ts: 131
LOW Client_JQuery_Deprecated_Symbols /apps/browser/src/background/runtime.background.ts: 94
LOW Client_JQuery_Deprecated_Symbols /apps/cli/src/commands/download.command.ts: 43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant