MB-35347: Synonyms interface support + MB-58901: fieldDict's cardinality API #25
+76
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thejas-bhat
requested review from
abhinavdangeti,
metonymic-smokey,
CascadingRadium and
Likith101
Pull Request Test Coverage Report for Build 12659729400Details
💛 - Coveralls |
|
@Thejas-bhat So looks like @CascadingRadium has missed updating the signature here for the interface he's changed in bleve_index_api for synonyms - let's wait for him to think through and propose the necessary changes here to support embedded synonyms search requests from the query engine. |
Addressed this in following commit. |
abhinavdangeti
approved these changes
Jan 8, 2025
abhinavdangeti
changed the title
abhinavdangeti
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.