Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX/UPDATE - i18n wallets connected string handling, formatting and version bumps #2326

Merged
merged 11 commits into from
Dec 27, 2024

Conversation

Adamj1232
Copy link
Member

@Adamj1232 Adamj1232 commented Dec 27, 2024

Description

This PR updates handling for missing i18n definitions noted in #2313
Also updated is the svelte-i18n version within core to help handle #2078
Bump WalletConnect package version
Some general formatting and type importing

Copy link

socket-security bot commented Dec 27, 2024

Report too large to display inline

View full report↗︎

@Adamj1232 Adamj1232 changed the title FIX - i18n wallets connected string handling, formatting and version bumps FIX/UPDATE - i18n wallets connected string handling, formatting and version bumps Dec 27, 2024
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Critical CVE npm/[email protected] ⚠︎

View full report↗︎

Next steps

What is a critical CVE?

Contains a Critical Common Vulnerability and Exposure (CVE).

Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@Adamj1232 Adamj1232 merged commit 7b54d8a into develop Dec 27, 2024
3 checks passed
@Adamj1232 Adamj1232 deleted the fix/i18n_wallets_connected branch December 27, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant