-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new languages to CFBundleLocalizations
key
#6835
Add new languages to CFBundleLocalizations
key
#6835
Conversation
If you could additionally help me adjust the Chinese part, that would be greatly appreciated. For various reasons, the language tags for Chinese are quite complex. I think both iOS and Android are more prefer
|
Done ✅
From the first reference:
I think this is why; After doing some more googling and coming across some other sources like this GitHub comment (updated CLDR Likely Subtags link) and seeing that these are the entries listed for Cantonese on my iPhone: what about changing the |
It's worth trying. 👍 I'm not sure if defining it directly as Also I before made changes related to Cantonese in #6621 to ensure that both |
Done ✅🤞
I went with
Oh yes I remember seeing that PR. Maintaining Cantonese localizations in both scripts might be a bit much, so probably the best solution 😅 |
OK let's see the results after the next App Store update. Thanks again! |
* Order tweak in lingui.config.js * Add new languages to `CFBundleLocalizations` key * Order tweak in dates.ts * hyphen to en-dash * change two `zh` tags to use script rather than region * `zh_HK` ➡️ `yue-Hant` * `pt` ➡️ `pt-BR`
#6567 added the languages supported as
AppLanguage
in aCFBundleLocalizations
key toInfo.plist
. This meant that with the release of 1.95, the supported languages now show up in the App Store listing, rather than just English being shown.It also meant that #6162 was resolved and allowed the
TextInput
context menus to be translated into the device language (if it's supported as anAppLanguage
).This PR adds the codes for the localizations merged since #6567 – Aragonese, Asturian, Galician, Dutch and Vietnamese – to the
CFBundleLocalizations
key so that they'll also be displayed in the App Store listing and users with their device set to Dutch or Vietnamese will have theTextInput
context menus translated. In future, thecode2
for a new language can simply be added as part of a localization PR.This PR also makes a couple of minor, unrelated tweaks to keep language codes in alphabetical order and to replace a couple of hyphens with en-dashes in the list for selecting an app language.
EDIT: I also made some changes to the Chinese & Cantonese language tags following @auroursa's suggestions, and I changed
pt
topt-BR
in anticipation of the forthcomingpt-PT
localization.