[ELI5] Validate too long handles in signup #7422
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks if a handle is too long in the signup flow. Handles can be up to 253 chars normally, but for PDS service handles the max is 30, including domain. I added an additional flag to the
validateHandle
function to lower the length check appropriately. I made it generic for other PDSes, rather than hard-coding 18 chars. I also corrected the logic in the change handle screen since that was hardcoded to 18.Test plan