Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #5 memory manager redesign #10

Merged
merged 100 commits into from
Aug 7, 2019
Merged

Issue #5 memory manager redesign #10

merged 100 commits into from
Aug 7, 2019

Conversation

holzkohlengrill
Copy link
Collaborator

Description tacked in #5

KGergo88 added 30 commits July 3, 2019 12:37
@KGergo88
Creating the new testing folder structure and adding tests and scripts
123dff5 
Details:
    - Adding script for generating unit test code coverage report generation
    - Ignoring the unit test code coverage reports
    - Adding unit tests for the memoryEntry.py::MemEntry class
@KGergo88
Bugfixes in the memoryEntry.py::MemEntry class based on the unit test…
007f3f3 
…ing results

Details:
    - Changing the order of parameter checking in order to be more testable
    - Adding TODO comments
    - Removing the equalSection and equalObject members because they were already implemented in subclasses
    - Code formatting
@KGergo88
Implementing the SectionEntry and ObjectEntry unit tests and bugfixes
8079462 
Details:
    - Implementing the SectionEntryTestCase
    - Implementing the ObjectEntryTestCase
    - The __eq__ will raise an exception in case of a not implemented type in SectionEntry and ObjectEntry from now on
@KGergo88
Creating the unit test structure of the test_memoryMap.py and adding …
138675f 
…a simple test case
@KGergo88
Implementing unit tests for MemoryMap.py::caluclateObjectsInSections(…
b7bfe55 
…) and bugfixes

Details:
    - Adding different test cases to test the MemoryMap.py::caluclateObjectsInSections() function
    - Bugfix in the MemoryMap.py::caluclateObjectsInSections() function
    - Defining an exception throwing empty __eq__ operator for the memoryEntry.py::MemEntry class
@KGergo88
Correcting the function names in the unit tests
641a7fb
@KGergo88
Correcting the names of constants in the unit tests
e70596d
@KGergo88
Getting update from branch 'master' into ISSUE_#3_Testing
8fe8d31
@KGergo88
Adding a functional test for the test_project
4a92bcf
@KGergo88
Replacing magic strings with constants in the test__test_project.py
503da71
@KGergo88
Adding comments, docstrings and type hints to the test__test_project.py
c663aca
@KGergo88
Creating the new files and sorting the members of the MemoryManager c…
2e7aed8 
…lass into other files

Details:
    - New files:
        - configuration.py
        - ghsConfiguration.py
        - mapfileProcessor.py
        - ghsMapfileProcessor.py
        - mapfileRegexes.py
        - ghsMapfileRegexes.py (this was the old mapfileRegexes.py)
@KGergo88
Partial implementation of the new classes
61e9572
@KGergo88
First working demo of the new design
7835c50
@KGergo88
Minor changes in logging, command line handling and function names
90735e7
@KGergo88
Further work on the redesign
c76766f
@KGergo88
Implementing the redesigned categorisation
aeed6f9
@KGergo88
Further progress on the MemoryManager redesign implementation
2b7b276
@KGergo88
Bugfixes, reorganisations, adding comments
2fc487d
@KGergo88
Further progress in the MemoryManager redesign
e9a22ee 
Details:
	- Renaming MemoryWrapper to MemoryHandler
	- Removing redundant members from the MemEntry class
	- Removing unused methods in the MemoryHandlers
	- Renaming __eq__() to isEqual() in the MemoryHandlers
	- Adding member functions to the MemEntry class to calculate different end and hex addresses
	- Fixing MemEntry usages in the SW
	- Minor logging changes
	- Renaming shadowing readArgument variables to commandLineArguments
	- Renaming validateConfiguration() to checkConfiguration()
	- Bugfix in the mapfileProcessor.py::fillOutMemoryRegionsAndMemoryTypes()
	- Bugfix in the memoryMap.py::calculateObjectsInSections::cutOffTheBeginningOfTheSection()
@KGergo88
Updating the unit tests after the redesign
3b3d699 
	Details:
		Adding the missing addressStartHexOriginal() method to the MemEntry
		Updating the test__memoryEntry.py
		Updating the test__memoryMap.py
@KGergo88
Finalizing the unit test for the MemEntry class
4db9d5d
@KGergo88
Implementing the missing tests in the test_memoryEntry.py
0150680
@KGergo88
Adding unit tests for the memoryMap.py::resolveDuplicateContainmentOv…
9a35ecb 
…erlap() and bugfixes

Details:
	- Fixing the bug in the overlap handling in memoryMap.py::resolveDuplicateContainmentOverlap()
	- Changing the isEqual() implementations so that they use the addressSize instead of the addressEnd()
	- Adding tests to the tests/unit_tests/test_memoryMap.py
@KGergo88
Adding unit tests for some of the functions in shared_libs/emma_helpe…
66b102a 
…r.py

Details:
    - Adding the unit_tests/test_emma_helper.py
    - Changing the sys.path.append() call in the unit tests
    - Fixing a docstring error in the shared_libs/emma_helper.py::toHumanReadable()
@KGergo88
Adding comments and docstrings and constants
5f11cc1 
	Details:
		- Adding constants that define the compiler names
		- Updating the test_project global config with the new compiler names
		- Updating the factories with the new compiler names
@KGergo88
Changing the constant COMPILER_NAME_GHS and updating the test_project
2955c70
@KGergo88
Removing the compiler specific data from the MemEntry class
1ab2ee9 
Details:
	- MemEntry:
		- Removing the members dma, vasName, vasSectionName
		- Adding the member compilerSpecificData
		- Adding default values and renaming parameters of the __init__()
		- addressStart, addressLength and addressEnd can be int and string as hex from now on
		- Renaming section to sectionName
		- Renaming moduleName to objectName
	- Renaming the constant MODULE_NAME to OBJECT_NAME (the term is GHS specific)
	- Renaming the constant TAG to the MEM_TYPE_TAG
	- Changing the order of the headers in the test__test_project.py
	- Changing the writeReportToDisk() to be able to handle the compilerSpecificData of the MemEntry
	- Changing the ghsMapfileProcessor() to create the compilerSpecificData as required by the MemEntry
	- Adding docstrings and comments to the memoryMap.py
	- Adding docstrings and comments to the memoryEntry.py
	- Adapting other parts of the code to the changes:
		- categorisation.py
		- mapfileProcessor.py
		- memoryMap.py
@KGergo88
Switching to the collections.OrderedDict as the type for MemEntry.com…
d8d6cb4 
…pilerSpecificData
@KGergo88
Updating unit tests with the changes in the MemEntry class and bugfixes
c34da22 
Details:
	- Fixed the bug of the addressEnd + addressLenght provided construction in the MemEntry
	- Reorganizing the test_memoryEntry.py and updating the tests with the changes
	- Updating the test_memoryMap.py
@bmwcarit bmwcarit deleted a comment Aug 7, 2019
@bmwcarit bmwcarit deleted a comment Aug 7, 2019
@bmwcarit bmwcarit deleted a comment Aug 7, 2019
@bmwcarit bmwcarit deleted a comment Aug 7, 2019
@KGergo88 KGergo88 changed the title WIP: Issue #5 memory manager redesign Issue #5 memory manager redesign Aug 7, 2019
@KGergo88
Copy link
Member

KGergo88 commented Aug 7, 2019

@holzkohlengrill: All points were implemented. Can I merge into master?

@bmwcarit bmwcarit deleted a comment Aug 7, 2019
@bmwcarit bmwcarit deleted a comment Aug 7, 2019
@bmwcarit bmwcarit deleted a comment Aug 7, 2019
@bmwcarit bmwcarit deleted a comment Aug 7, 2019
@bmwcarit bmwcarit deleted a comment Aug 7, 2019
@bmwcarit bmwcarit deleted a comment Aug 7, 2019
@KGergo88 KGergo88 marked this pull request as ready for review August 7, 2019 16:23
@bmwcarit bmwcarit deleted a comment Aug 7, 2019
@KGergo88 KGergo88 merged commit 4b4aaf6 into master Aug 7, 2019
@holzkohlengrill holzkohlengrill deleted the ISSUE_#5_MemoryManagerRedesign branch May 4, 2020 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KGergo88 KGergo88 KGergo88 approved these changes

Assignees

@KGergo88 KGergo88

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@holzkohlengrill @KGergo88