-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Be/feature/#598 사용자 api 및 서비스 구현 #599
Merged
The head ref may contain hidden characters: "BE/feature/#598-\uC0AC\uC6A9\uC790-API-\uBC0F-\uC11C\uBE44\uC2A4-\uAD6C\uD604"
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
사용자의 닉네임 및 프로필 URL 조회
프로퍼티명과 변수명이 동일한 경우 이름 생략
- 단위 테스트, e2e 테스트를 위한 jest 설정이 거의 유사하지만 중복으로 정의되어 있었음 - 이를 js를 통해 동적으로 설정해주도록 구현함 - jest.config.json : 공통 부분 정의 - jest.config.js : 파라미터를 전달받아 동적으로 jest 설정정보 구성 - jest-unit.config.js & jest-e2e.config.js : 각각 단위/e2e 테스트를 위한 설정정보를 반환하는 함수
HeoJiye
approved these changes
Mar 6, 2024
Doosies
approved these changes
Mar 6, 2024
Comment on lines
+3
to
+11
export const MEMBERS_CODEMAP: ExceptionCodemap = { | ||
NOT_FOUND: { | ||
status: 404, | ||
message: '사용자를 찾을 수 없습니다.', | ||
code: 'MME001', | ||
description: | ||
'해당 이메일에 해당하는 사용자가 존재하지 않습니다. 쿠키에 들어있는 email, providerId가 올바른지 확인해주세요.', | ||
}, | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 👍 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔮 resolved #598
변경 사항
1️⃣ 쿠키 정보(jwt)를 바탕으로 사용자 정보 조회하기
2️⃣ 단위 테스트, e2e 테스트를 위한 설정 중복 해결
jest.config.json
작성jest-unit.config.js
작성jest-e2e.config.js
작성고민과 해결 과정
(선택) 테스트 결과