Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error build if ICU or IConv support was requested but is not available. #247

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Flamefire
Copy link
Collaborator

This checks for the explicit commandline setting.

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.88%. Comparing base (6b79d8b) to head (ee767a7).

❗ There is a different number of reports uploaded between BASE (6b79d8b) and HEAD (ee767a7). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (6b79d8b) HEAD (ee767a7)
3 2
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #247       +/-   ##
============================================
- Coverage    95.84%   78.88%   -16.97%     
============================================
  Files          117       94       -23     
  Lines        10410     7500     -2910     
============================================
- Hits          9977     5916     -4061     
- Misses         433     1584     +1151     

see 106 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b79d8b...ee767a7. Read the comment docs.

This checks for the explicit commandline setting.
@Flamefire Flamefire force-pushed the error-on-unmet-dep branch 2 times, most recently from 929e895 to a989201 Compare December 14, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant