Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOAZ-372 Support for deployment in Azure Government Cloud (Cromwell) #7670

Merged
merged 9 commits into from
Jan 7, 2025

Conversation

bennettn4
Copy link
Contributor

@bennettn4 bennettn4 commented Dec 10, 2024

Part of large effort to add support for services to run in Azure Government cloud.

  • Added config value azure-environment
  • Added config value token-scope-management

https://broadworkbench.atlassian.net/browse/TOAZ-372
See related pull requests here:
workbench-libs sam bpm wsm cromwell terra-helmfile

CHANGELOG.md

  • I updated CHANGELOG.md in this PR
  • I assert that this change shouldn't be included in CHANGELOG.md because it doesn't impact community users

Terra Release Notes

  • I added a suggested release notes entry in this Jira ticket
  • I assert that this change doesn't need Jira release notes because it doesn't impact Terra users

@bennettn4 bennettn4 marked this pull request as ready for review December 10, 2024 16:21
@bennettn4 bennettn4 requested a review from a team as a code owner December 10, 2024 16:21
@jgainerdewar jgainerdewar changed the title Support for deployment in Azure Government Cloud (Cromwell) TOAZ-372 Support for deployment in Azure Government Cloud (Cromwell) Dec 10, 2024
@@ -330,6 +330,11 @@ call-caching {
max-failed-copy-attempts = 1000000
}

azure {
azure-environment = "AZURE"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be AzureCloud?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, fixed

@jsaun jsaun enabled auto-merge (squash) January 7, 2025 22:00
@jsaun jsaun merged commit 920759a into develop Jan 7, 2025
43 checks passed
@jsaun jsaun deleted the bennettn/azure-gov-update branch January 7, 2025 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants