shared notification url formatting #4572
Merged
+59
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanars
commented
Jan 7, 2025
| calls = [] | ||
| for notif_dict in expected_notifs: | ||
| project_guid = notif_dict.get('project_guid', PROJECT_GUID) | ||
| project_name = notif_dict.get('project_name', '1kg project nåme with uniçøde') | ||
| url = f'https://test-seqr.org/project/{project_guid}/project_page' | ||
| project_link = f'<a href={url}>{project_name}</a>' if has_html else f'<{url}|{project_name}>' | ||
| project_link = f'<a href={url}>{project_name}</a>' |
There was a problem hiding this comment.
this test change reflects the actual bug fix - we should never be sending an email with the URL formatted in anything other than html
jklugherz
reviewed
Jan 9, 2025
seqr/utils/communication_utils.py
Outdated
| users = project.subscribers.user_set.all() | ||
| notify.send(project, recipient=users, verb=notification) | ||
| notify.send(project, recipient=users, verb=f'{notification_prefix}{notification}') |
There was a problem hiding this comment.
I don't see notification_prefix being overridden in any calls to send_project_notification, can we remove it and make the verb f'Loaded {notification}')?
…malize-project-notifications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
email notification for RNA loading did not include the project name/URL because we were sending it with a url formatted for slack instead of regular html. Since most notification include links to projects and this is an easy mistake to make I updated the
send_project_notificationhelper function to handle slack as well as email notification and to handle constructing the URL for each in the helper instead of having the URL passed in by the calling function. This fixes the bug and also means that this is less likely to happen again in the future. In the process of unifying the functionality there are some slight differences to some of the slack/email messages being generatdd by this helper but they should all be either improvements or at worst neutral changes