Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish to PyPI #182

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Publish to PyPI #182

merged 3 commits into from
Mar 5, 2024

Conversation

kmilo9999
Copy link
Collaborator

@kmilo9999 kmilo9999 commented Mar 5, 2024 •
edited
Loading

  • Labeled as pre-release

@kmilo9999 kmilo9999 requested a review from cpaniaguam March 5, 2024 18:10
@kmilo9999 kmilo9999 mentioned this pull request Mar 5, 2024
Merged
hollandjg
hollandjg requested changes Mar 5, 2024
View reviewed changes
Copy link
Member

@hollandjg hollandjg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Camilo! Couple of changes here!

.github/workflows/publish_pypi.yml Outdated Show resolved Hide resolved
.github/workflows/publish_pypi.yml Outdated Show resolved Hide resolved
cpaniaguam
cpaniaguam reviewed Mar 5, 2024
View reviewed changes
Copy link
Member

@cpaniaguam cpaniaguam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment about adding the prospective package name to the yml file.

.github/workflows/publish_pypi.yml Show resolved Hide resolved
cpaniaguam
cpaniaguam approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@cpaniaguam cpaniaguam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

hollandjg
hollandjg approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@hollandjg hollandjg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

@kmilo9999 kmilo9999 merged commit cc20709 into main Mar 5, 2024
2 checks passed
@kmilo9999 kmilo9999 deleted the ft-switch-publish branch March 5, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpaniaguam cpaniaguam cpaniaguam approved these changes

@hollandjg hollandjg hollandjg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kmilo9999 @hollandjg @cpaniaguam