Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature step6 integration #52

Merged
merged 6 commits into from
Jan 31, 2024
Merged

Feature step6 integration #52

merged 6 commits into from
Jan 31, 2024

Conversation

kmilo9999
Copy link
Collaborator

  • Added file analysis_db/B05_define_angle.py for step 6
  • Cleaned code
  • Formatted file

Base automatically changed from feat-step5-intg to main January 29, 2024 14:27
cpaniaguam
cpaniaguam previously approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@cpaniaguam cpaniaguam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

B05_define_angle needs to be cleaned up. I'll do this when the file is added to the cli.

src/icesat2_tracks/analysis_db/B05_define_angle.py Show resolved Hide resolved
hollandjg
hollandjg requested changes Jan 29, 2024
View reviewed changes
Copy link
Member

@hollandjg hollandjg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could you delete the old version of the file so we can see the diff in the GitHub files view? Thanks!

src/icesat2_tracks/analysis_db/B05_define_angle.py Show resolved Hide resolved
src/icesat2_tracks/analysis_db/B05_define_angle.py Show resolved Hide resolved
@kmilo9999 kmilo9999 requested a review from hollandjg January 29, 2024 19:18
hollandjg
hollandjg reviewed Jan 29, 2024
View reviewed changes
Copy link
Member

@hollandjg hollandjg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've a couple of questions around the edges – nothing major. It looks like just moving the file b05 and then reformatting it.

src/icesat2_tracks/analysis_db/B05_define_angle.py Outdated Show resolved Hide resolved
src/icesat2_tracks/analysis_db/B05_define_angle.py Outdated Show resolved Hide resolved
@hollandjg hollandjg self-requested a review January 29, 2024 21:36
@cpaniaguam cpaniaguam mentioned this pull request Jan 29, 2024
Closed
hollandjg
hollandjg approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@hollandjg hollandjg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

This was referenced Jan 31, 2024
Open
Closed
@kmilo9999 kmilo9999 merged commit 41b948b into main Jan 31, 2024
1 check passed
@kmilo9999 kmilo9999 deleted the feat-step6-intg branch January 31, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpaniaguam cpaniaguam cpaniaguam left review comments

@mochell mochell mochell left review comments

@hollandjg hollandjg hollandjg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kmilo9999 @hollandjg @mochell @cpaniaguam