fixed issue and made the dashboard bold the max value of each set #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fredenck
requested changes
Dec 1, 2024
There was a problem hiding this comment.
logic is wrong, we don't want to bold the max of all player sets; we want to bold if a player won their specific set against a player. For example, this should bold both 6 and 7 for Timothy because he won both sets (7-5, 6-1).
Please re-read the issue, I've made a few clarifications
|
Additionally, make sure to run |
made sure the winning score for the bolding issue is fixed, so only the winning score is bolded
|
redone with #267 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed issue and made the dashboard bold the max value of each set - should work for issue
