Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpctest: make sure to WaitForShutdown #2277

Merged
merged 1 commit into from
Dec 10, 2024
Merged

rpctest: make sure to WaitForShutdown #2277

merged 1 commit into from
Dec 10, 2024

Conversation

yyforyongyu
Copy link
Collaborator

Make sure to call WaitForShutdown in the itest.

@coveralls
Copy link

coveralls commented Nov 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12143182985

Details

  • 2 of 4 (50.0%) changed or added relevant lines in 1 file are covered.
  • 14 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 57.243%
Changes Missing Coverage Covered Lines Changed/Added Lines %
integration/rpctest/rpc_harness.go 2 4 50.0%
Files with Coverage Reduction New Missed Lines %
peer/peer.go 14 73.49%
Totals Coverage Status
Change from base Build 12142686341: -0.01%
Covered Lines: 29889
Relevant Lines: 52214
💛 - Coveralls

@yyforyongyu yyforyongyu mentioned this pull request Nov 26, 2024
Merged
@yyforyongyu
Copy link
Collaborator Author

hold on i think it's breaking all test cases in lnd...

@yyforyongyu
Copy link
Collaborator Author

ok it's broken since this #2272

@yyforyongyu
Copy link
Collaborator Author

Now that the above issue is fixed think this can be merged.

@guggero
Copy link
Collaborator

guggero commented Dec 4, 2024

Need another green review checkmark, don't have the perms to override merge otherwise... cc @Roasbeef

Roasbeef
Roasbeef approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍺

@Roasbeef Roasbeef merged commit e646d43 into btcsuite:master Dec 10, 2024
3 checks passed
@yyforyongyu yyforyongyu deleted the fix-shutdown-itest branch December 10, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellemouton ellemouton ellemouton approved these changes

@guggero guggero guggero approved these changes

@Roasbeef Roasbeef Roasbeef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yyforyongyu @coveralls @guggero @Roasbeef @ellemouton