Update dependencies and tools to target API 33 #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like the build failed because the KSPASS variable was missing in the CI pipeline. Not really sure why though. |
Zerwin
force-pushed
the
update-dependencies-33
branch
from
fd15ec2 to
b8d86d8
Compare
FoseFx
reviewed
Aug 26, 2024
| @@ -21,6 +21,14 @@ public EmoticonToken(String text, String id) { | |||
| this.id = id; | |||
| } | |||
|
|
|||
| public final String component1() { | |||
There was a problem hiding this comment.
TokenizerTest still uses these functions
Although in hindsight adjusting the test would probably be the better way forward.
Sounds good to me, as it mostly touches files that aren't usually changed in rebases it shouldn't be a problem to do this later. |
Co-authored-by: Max Baumann <[email protected]>
Co-authored-by: Max Baumann <[email protected]>
Zerwin
force-pushed
the
update-dependencies-33
branch
from
9d29975 to
1a6339f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Updates the dependencies, Gradle and build tools. Several linting warnings and errors are also fixed.
Checklist
I use the "bttv_" prefix for all resources I proposeWhen adding a string I also added it to thebttv.Res.stringsEnum andres/values/strings.xml(inmod) andres/values/public.xml(indisass)If my change is significant enough, I added it to the CHANGELOG.md undermasterI'll add myself and everyone else who contributed to this change to the contributors list using all-contributorsI did not run ubi, because the build tools 33 use d8 instead of dx now but ubi itself seems to have dx hardcoded in some places.