Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IVS-157 single component #331

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

aothms
Copy link
Collaborator

@aothms aothms commented Dec 22, 2024

Implementation is trivial, but depends on networkx. Test files include also the TAS mirror image, will be moved later after review.

@Ghesselink
Copy link
Contributor

A little nitpicking from my side;

  • Already fixed, but the naming of the feature file (the actual .feature filename) was not consistent with the others (a hyphen instead of an underscore after the rulecode); the protocol checks spotted this.
  • The versioning tag was @version2 (also fixed). If this was intentional, feel free to revert of course.
  • The presnet rule-tag is @GEM. The other @BRP(001) rule has both @GEM and @BRP tags. I'm not sure whether we should have both tags here as well.

Test files include also the TAS mirror image, will be moved later after review.

When I remove these files manually, the tests pass :-)

collected 8 items                                                                                                                                             

test/test_main.py 
fail-brp002-closed_shell_reused_points_2_components.ifc

1 activating outcome(s)
1 error(s)
┌──────────────────────────────┬────────────────────────────────┬──────────────────────────────┬────────────┬────────────────────────────────┬────────┐
│ Feature                      │ Scenario                       │ Last Step                    │   Instance │ Message                        │ Code   │
├──────────────────────────────┼────────────────────────────────┼──────────────────────────────┼────────────┼────────────────────────────────┼────────┤
│ BRP002 - Single component in │ IfcConnectedFaceSet components │ all edges must form a single │         53 │ Expected : all edges must form │ E00050 │
│ connected faceset - v1       │                                │ connected component          │            │ a single connected component,  │        │
│                              │                                │                              │            │ Observed : {'value': 2}        │        │
└──────────────────────────────┴────────────────────────────────┴──────────────────────────────┴────────────┴────────────────────────────────┴────────┘
.
pass-brp002-open_shell_reused_points_1_components.ifc

1 activating outcome(s)
0 error(s)
.
pass-brp002-closed_shell_reused_points_1_components.ifc

1 activating outcome(s)
0 error(s)
.
fail-brp002-open_shell_non_reused_points_2_components.ifc

1 activating outcome(s)
1 error(s)
┌──────────────────────────────┬────────────────────────────────┬──────────────────────────────┬────────────┬────────────────────────────────┬────────┐
│ Feature                      │ Scenario                       │ Last Step                    │   Instance │ Message                        │ Code   │
├──────────────────────────────┼────────────────────────────────┼──────────────────────────────┼────────────┼────────────────────────────────┼────────┤
│ BRP002 - Single component in │ IfcConnectedFaceSet components │ all edges must form a single │         15 │ Expected : all edges must form │ E00050 │
│ connected faceset - v1       │                                │ connected component          │            │ a single connected component,  │        │
│                              │                                │                              │            │ Observed : {'value': 2}        │        │
└──────────────────────────────┴────────────────────────────────┴──────────────────────────────┴────────────┴────────────────────────────────┴────────┘
.
fail-brp002-open_shell_reused_points_2_components.ifc

1 activating outcome(s)
1 error(s)
┌──────────────────────────────┬────────────────────────────────┬──────────────────────────────┬────────────┬────────────────────────────────┬────────┐
│ Feature                      │ Scenario                       │ Last Step                    │   Instance │ Message                        │ Code   │
├──────────────────────────────┼────────────────────────────────┼──────────────────────────────┼────────────┼────────────────────────────────┼────────┤
│ BRP002 - Single component in │ IfcConnectedFaceSet components │ all edges must form a single │         23 │ Expected : all edges must form │ E00050 │
│ connected faceset - v1       │                                │ connected component          │            │ a single connected component,  │        │
│                              │                                │                              │            │ Observed : {'value': 2}        │        │
└──────────────────────────────┴────────────────────────────────┴──────────────────────────────┴────────────┴────────────────────────────────┴────────┘
.
pass-brp002-closed_shell_non_reused_points_1_components.ifc

1 activating outcome(s)
0 error(s)
.
pass-brp002-open_shell_non_reused_points_1_components.ifc

1 activating outcome(s)
0 error(s)
.
fail-brp002-closed_shell_non_reused_points_2_components.ifc

1 activating outcome(s)
1 error(s)
┌──────────────────────────────┬────────────────────────────────┬──────────────────────────────┬────────────┬────────────────────────────────┬────────┐
│ Feature                      │ Scenario                       │ Last Step                    │   Instance │ Message                        │ Code   │
├──────────────────────────────┼────────────────────────────────┼──────────────────────────────┼────────────┼────────────────────────────────┼────────┤
│ BRP002 - Single component in │ IfcConnectedFaceSet components │ all edges must form a single │         85 │ Expected : all edges must form │ E00050 │
│ connected faceset - v1       │                                │ connected component          │            │ a single connected component,  │        │
│                              │                                │                              │            │ Observed : {'value': 2}        │        │
└──────────────────────────────┴────────────────────────────────┴──────────────────────────────┴────────────┴────────────────────────────────┴────────┘

@Ghesselink
Copy link
Contributor

I've also deployed locally and tested the platform and it behaves as expected (i.e. failing testfiles are failing, passing are activated/green).

but depends on networkx.
Added this to the validate repo

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants