This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
#115: Handle tagged unions with fewer than two cases (closes #115) #116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes [#2520856](https://buildo.kaiten.io/space/[object Object]/card/2520856)
Closes #115
Single-case tagged unions are now converted simply to interface declarations like
without the erroneous union combinator.
Zero-case tagged unions are just skipped in the output.
The rationale for this is that they're not really useful right now for us because we're not generating precise types for errors (the left side of route
TaskEither
s) and zero-case tagged unions only make sense in the error type, not in the main route type or as field of another module.To move to more precise error handling, we should change this to output these types as synonyms for
never
, with an appropriate codec (perhaps one that always fails, probably actually anything that typechecks is fine since it won't be used).Test Plan