Readme update issue #58 #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aswin Timalsina <[email protected]>
Signed-off-by: Aswin Timalsina <[email protected]>
jkutner
reviewed
May 7, 2021
README.md
Outdated
| @@ -23,7 +23,7 @@ GET /search | |||
|
|
|||
| | Name | Type | Description | Example | | |||
| | ------- | ------- | ------- | ------- | | |||
| | **matches** | *string* | keyword(s) to search for | `"java"` | |||
| | **matches** | *string* | keyword(s) to search for | `"projectriff"` | |||
There was a problem hiding this comment.
We should get rid of the projectriff references because it's been EOL'ed. If the "java" doesn't match up somewhere else, let's change those places instead.
jkutner
requested changes
May 7, 2021
Signed-off-by: Aswin Timalsina <[email protected]>
|
Do you want me to replace other occurrences of |
|
@AswinTimalsina yes please |
Signed-off-by: Aswin Timalsina <[email protected]>
|
Tried "java" as the keyword, but the response was too long. So I used "ruby" as the keyword. I am not sure if it is okay to use it. Please let me know. |
jkutner
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revised
Developmentsection of the readme and fixed some minor.issue #58