Fix code scanning alert no. 2: SQL query built from user-controlled sources #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ources Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/burrito-party/advanced-security-python/security/code-scanning/2
The best way to fix the problem is to use parameterized queries, which safely embed user-provided data into the query. This approach ensures that the database connector library handles the escaping and quoting of the input data, preventing SQL injection attacks.
To implement this fix, we need to modify the
cursor.executecalls to use query parameters instead of string concatenation. Specifically, we will replace the concatenated SQL strings with parameterized queries and pass the user-provided data as parameters.Suggested fixes powered by Copilot Autofix. Review carefully before merging.