Skip to content

Commit

Permalink
fix lint
Browse files Browse the repository at this point in the history
  • Loading branch information
gossi committed Jan 24, 2024
1 parent 5d3b936 commit 5399bc9
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 8 deletions.
8 changes: 1 addition & 7 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -1,7 +1 @@
{
"eslint.packageManager": "pnpm",
"eslint.workingDirectories": [
"ember-link",
"test-app"
]
}
{}
2 changes: 1 addition & 1 deletion test-app/app/app.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import Application from '@ember/application';

import loadInitializers from 'ember-load-initializers';
import Resolver from 'ember-resolver';

import config from './config/environment';
import Resolver from 'ember-resolver';

export default class DummyApp extends Application {
modulePrefix = config.modulePrefix;
Expand Down
2 changes: 2 additions & 0 deletions test-app/tests/unit/test-helpers/link-for-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import type { LinkParams } from 'ember-link';
module('Unit | Test Helpers | linkFor', function (hooks) {
setupTest(hooks);

// eslint-disable-next-line qunit/require-expect
test('it calls linkManager.createUILink with correct arguments when passed parameters as an object', async function (assert) {
assert.expect(3);

Expand All @@ -32,6 +33,7 @@ module('Unit | Test Helpers | linkFor', function (hooks) {
linkFor({ route, models, query });
});

// eslint-disable-next-line qunit/require-expect
test('it calls linkManager.createUILink with correct arguments when passed parameters directly', async function (assert) {
assert.expect(3);

Expand Down
3 changes: 3 additions & 0 deletions test-app/tests/unit/test-helpers/test-link-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ module('Unit | Test Helpers | TestLink', function (hooks) {
assert.ok(link.url.match(/ember\d+/g), 'generates a GUID using `guidFor`');
});

// eslint-disable-next-line qunit/require-expect
test('it can overwrite properties', async function (assert) {
const properties = [
'isActive',
Expand Down Expand Up @@ -75,6 +76,7 @@ module('Unit | Test Helpers | TestLink', function (hooks) {
assert.strictEqual(link.url, 'my-url');
});

// eslint-disable-next-line qunit/require-expect
test('it fires onTransitionTo when transitionTo is called', async function (assert) {
assert.expect(2);

Expand All @@ -94,6 +96,7 @@ module('Unit | Test Helpers | TestLink', function (hooks) {
} as Event);
});

// eslint-disable-next-line qunit/require-expect
test('it fires onReplaceWith when replaceWith is called', async function (assert) {
assert.expect(2);

Expand Down

0 comments on commit 5399bc9

Please sign in to comment.