Modernize the project by adding native Typescript types. Making a class #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresgutgon
force-pushed
the
feature/esm-typescript-container
branch
3 times, most recently
from
56c5502 to
f8c6c9a
Compare
TopBar that can be imported as an ESM project. And added container option because I saw in an open issue. Also moved the tooling for minimizing to Rollup which allow minification with terser but aslo Typescript transpilation and differen export module formats
andresgutgon
force-pushed
the
feature/esm-typescript-container
branch
from
f8c6c9a to
fccad96
Compare
andresgutgon
commented
Nov 1, 2024
| ], | ||
| "version": "3.0.0", | ||
| "version": "3.0.1", |
There was a problem hiding this comment.
I think a patch version is fine here. If I did it ok previous behaviour should still work. I tried documentation page and it keeps working as a script.
The difference is that now people can import as ESM module
// ./src/app.ts
import { Topbar } from 'topbar' // ? I don't think is jet published
declare global {
interface Window {
topbar: Topbar
}
}
window.topbar = new Topbar({
barColors: {
0: 'rgba(255, 153, 153, .9)',
'.17': 'rgba(255, 204, 153, .9)',
'.34': 'rgba(255, 255, 153, .9)',
'.51': 'rgba(153, 255, 153, .9)',
'.68': 'rgba(153, 204, 255, .9)',
'.85': 'rgba(204, 153, 255, .9)',
'1.0': 'rgba(204, 153, 255, .9)',
},
shadowColor: 'rgba(0, 0, 0, .1)',
})
There was a problem hiding this comment.
I'm just watching this project but here's my two cents.
IMO, a minor version bump is more appropriate for this PR. Bumping the patch version is reserved just for patches (bug fixes). Since this PR isn't fixing bugs but rather adding new features, a minor bump would be the better way to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
TopBar can be imported as an ESM project. And added the
containeroption because I saw it as an open issueI also moved the tooling for minimizing to Rollup which allows minification with terser but also Typescript transpilation and different export module formats
Open question
Do you have an npm link. I think it would be great to publish as an NPM package.