-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRAFT: Adding JSPI and Asyncify #518
Draft
calvinrp
wants to merge
35
commits into
bytecodealliance:main
Choose a base branch
from
calvinrp:jspi
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
66f41b5
wip
calvinrp 0152f75
clean up
calvinrp d9c0796
clippy fixes
calvinrp 4fc199d
wip on asyncify
calvinrp 449ffef
prototyping
calvinrp 94d160e
added asyncify logic
calvinrp ed0dd1a
clean up
calvinrp f4b37b0
fix
calvinrp 807c47b
added jco CLI args for async mode
calvinrp 1652b89
fix
calvinrp cfb8af6
updated docs
calvinrp 11f2b0e
fixes and added default async imports and exports
calvinrp 0c16d11
fix for the optimizeComponent byte range
calvinrp 65c533f
added ts for async
calvinrp 9953b63
fixed cli types subcommand
calvinrp d783d85
updated asyncify instatiate
calvinrp c9d9daf
updated docs
calvinrp 60ce5c0
fix
calvinrp 09f7022
fixes
calvinrp b75cc48
renamed if_async to maybe_async
calvinrp a55c0d6
added first test
calvinrp fc026fa
moved asyncify functions to intrinsics; added an option to still use …
calvinrp 88fafd3
calls the async wrapper func at initialization time
calvinrp cfe3251
removed duplicate type def
calvinrp 62f9896
added more transpile options
calvinrp 3473a00
updated test
calvinrp ca94f4d
added jspi test
calvinrp 1f18fcf
feature detect jspi support in test suite
calvinrp e209a8c
fix for test
calvinrp f218fef
starting to setup wasi shims for async
calvinrp 748077e
added async WASI P2 shims
calvinrp 5314a5e
typo fix in refactor
calvinrp b2ea7b7
added ability to set stdin
calvinrp b9a8f25
added strip-debug
calvinrp 93df040
fixes
calvinrp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since components can contain multiple sub-components, this is currently joining imports and exports across all sub-components.
If we only consider the outer component import and exports, then we should restrict to that, but we can't do that either since internal components must be async if the outer component is!
Therefore I think we should probably restrict this to outer component imports only
And we should make exports all async as soon as we go into asyncify mode. This also will then help avoid the easy footgun of inadvertantly not making an export async, and then finding it calls an async import down the line which would trap.